Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 769005 - sys-devel/llvm-roc: sane default for --rocm-path
Summary: sys-devel/llvm-roc: sane default for --rocm-path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-06 16:28 UTC by Benda Xu
Modified: 2021-02-06 17:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2021-02-06 16:28:35 UTC
When compiling rocm targets, --rocm-path is a must to inform llvm-roc on the directory of the device-libs.  On Gentoo the AMD GPU device-libs is predictable to be in ${EROOT}/usr/lib/amdgcn/bitcode, which should be the default for llvm-roc.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2021-02-06 17:26:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f254242a3cbefe3f657384c06de728191633a28

commit 1f254242a3cbefe3f657384c06de728191633a28
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2021-02-06 17:24:02 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2021-02-06 17:26:15 +0000

    sys-devel/llvm-roc: set default device-libs.
    
    Disable HIP runtime check, it is not needed for Gentoo.
    
    Only the patch is updated, directly move 4.0.0-r1 to -r2.
    
    Closes: https://bugs.gentoo.org/769005
    Package-Manager: Portage-3.0.12, Repoman-3.0.1
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 .../files/llvm-roc-4.0.0-hip-location.patch        | 39 +++++++++++++++++++++-
 ...oc-4.0.0-r1.ebuild => llvm-roc-4.0.0-r2.ebuild} |  0
 2 files changed, 38 insertions(+), 1 deletion(-)
Comment 2 Larry the Git Cow gentoo-dev 2021-02-06 17:46:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/sci.git/commit/?id=319b6fff780a8aa60c3104972505d1999c8988ae

commit 319b6fff780a8aa60c3104972505d1999c8988ae
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2021-02-06 17:46:02 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2021-02-06 17:46:02 +0000

    sci-libs/rocBLAS: get rid of --rocm-path.
    
    The new revision of llvm-roc has a correct default for --rocm-path.
    
    Bug: https://bugs.gentoo.org/769005
    Package-Manager: Portage-3.0.12, Repoman-3.0.1
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 sci-libs/rocBLAS/rocBLAS-4.0.0-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)