Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768981 - app-emulation/virt-manager[gtk]: please remove net-misc/x11-ssh-askpass dependency
Summary: app-emulation/virt-manager[gtk]: please remove net-misc/x11-ssh-askpass depen...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-06 14:14 UTC by WGH
Modified: 2022-01-25 15:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WGH 2021-02-06 14:14:41 UTC
app-emulation/virt-manager[gtk] depends on net-misc/x11-ssh-askpass.

First, this is not a hard dependency. Some people use virt-manager to manage localhost, and thus don't need SSH access. Some people use SSH, but use public key auth, and thus don't need SSH_ASKPASS program either.

Second, net-misc/x11-ssh-askpass is just one SSH_ASKPASS program implementation. There're several others in Gentoo available, like lxqt-openssh-askpass, ssh-askpass-fullscreen, etc.

Third, net-misc/x11-ssh-askpass is an ancient program that pulls in imake build tools. The imake build system includes the infamous cleanlinks program, that can wreak some havoc if run accidentally[1][2]. I've been bitten by this myself.

A good solution IMO would be to suggest some SSH_ASKPASS programs in the "after installation" message, like I've seen with some other ebuilds.

[1] https://blog.winny.tech/2019-08-02-the-danger-of-fuzzy-matching-over-ones-path.html
[2] http://forums.debian.net/viewtopic.php?p=153898

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2022-01-25 15:11:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b1dfb30a241dd1aee0897d997ba6f8dd073f336

commit 0b1dfb30a241dd1aee0897d997ba6f8dd073f336
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-01-25 15:04:45 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-01-25 15:10:30 +0000

    app-emulation/virt-manager: update EAPI on 3.2.0-r1, use optfeature
    
     - drop useless runtime-only dependency for net-misc/x11-ssh-askpass.
    
    Closes: https://bugs.gentoo.org/768981
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../virt-manager/virt-manager-3.2.0-r1.ebuild      | 96 ++++++++++++++++++++++
 .../virt-manager/virt-manager-9999.ebuild          | 23 +++---
 2 files changed, 106 insertions(+), 13 deletions(-)