Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768948 - dev-db/lmdb-0.9.27: Deletion causes cursor to repeat
Summary: dev-db/lmdb-0.9.27: Deletion causes cursor to repeat
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Eray Aslan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 762110
  Show dependency tree
 
Reported: 2021-02-06 09:24 UTC by Michał Górny
Modified: 2021-02-18 20:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-06 09:24:50 UTC
I'm sorry but I haven't been able to find the exact details what the bug is.

From dev-python/lmdb:

+2021-02-05 v1.1.1
+* Dowgrade underlying LMDB to 0.9.26.  0.9.27 has a minor defect that will
+  need to get resolved.

+    def testIterWithDeletes(self):
+        ''' A problem identified in LMDB 0.9.27 '''
+        self.c.put(b'\x00\x01', b'hehe', dupdata=True)
+        self.c.put(b'\x00\x02', b'haha', dupdata=True)
+        self.c.set_key(b'\x00\x02')
+        it = self.c.iternext()
+        self.assertEqual((b'\x00\x02', b'haha'), next(it))
+        self.txn.delete(b'\x00\x01', b'hehe', db=self.db)
+        self.assertRaises(StopIteration, next, it)
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-06 09:25:09 UTC
I don't see any new commits in the upstream repo, so if you could add 0.9.26, that'd be a reasonable compromise.
Comment 2 Larry the Git Cow gentoo-dev 2021-02-06 23:49:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65549bffda443a0356f9ba5e2353c4c0a3c61201

commit 65549bffda443a0356f9ba5e2353c4c0a3c61201
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-06 23:49:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-06 23:49:29 +0000

    dev-db/lmdb: reset 0.9.27 to ~arch
    
    Unclear "minor defect" so we should
    downgrade for now.
    
    Bug: https://bugs.gentoo.org/762110
    Bug: https://bugs.gentoo.org/768948
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/lmdb/lmdb-0.9.27.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-02-10 16:51:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a88c3ec4dffc3aef1d3b83070b3dbae29f7e164

commit 3a88c3ec4dffc3aef1d3b83070b3dbae29f7e164
Author:     Eray Aslan <eras@gentoo.org>
AuthorDate: 2021-02-10 16:50:53 +0000
Commit:     Eray Aslan <eras@gentoo.org>
CommitDate: 2021-02-10 16:50:53 +0000

    dev-db/lmdb: add 0.9.26 to the tree
    
    Bug: https://bugs.gentoo.org/768948
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Eray Aslan <eras@gentoo.org>

 dev-db/lmdb/Manifest           |  1 +
 dev-db/lmdb/lmdb-0.9.26.ebuild | 75 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)
Comment 5 Eray Aslan gentoo-dev 2021-02-10 16:53:38 UTC
- 0.9.26 added to the tree
- 0.9.28 is released in the meantime but does not contain the fix for this bug
- 0.9.28 with the fix applied fails tests.  will see what I can do
Comment 6 Larry the Git Cow gentoo-dev 2021-02-11 14:40:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2bba4156bcf48edc838a0e452d3bea1a82d42ea9

commit 2bba4156bcf48edc838a0e452d3bea1a82d42ea9
Author:     Eray Aslan <eras@gentoo.org>
AuthorDate: 2021-02-11 14:39:55 +0000
Commit:     Eray Aslan <eras@gentoo.org>
CommitDate: 2021-02-11 14:40:25 +0000

    dev-db/lmdb: bump to 0.9.28
    
    and fix cursor delete bug introduced with 0.9.27
    
    Closes: https://bugs.gentoo.org/768948
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Eray Aslan <eras@gentoo.org>

 dev-db/lmdb/Manifest                           |  1 +
 dev-db/lmdb/files/lmdb-fix-cursor-delete.patch | 48 ++++++++++++++++
 dev-db/lmdb/lmdb-0.9.28.ebuild                 | 79 ++++++++++++++++++++++++++
 3 files changed, 128 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2021-02-18 20:15:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5cc7782cd993626aa67ccff0d938413f64f27ad

commit a5cc7782cd993626aa67ccff0d938413f64f27ad
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-18 20:15:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-18 20:15:30 +0000

    profiles/package.mask: mask broken dev-db/lmdb-0.9.27 version
    
    (Until we're ready to remove it for sure).
    
    Bug: https://bugs.gentoo.org/768948
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)