Created attachment 685905 [details] celluloid-9999.ebuild universal, should also work for releases emerge and run tested
Created attachment 712971 [details] celluloid-9999.ebuild universal gtk4 universal, should also work for next gtk4 based releases emerge and run tested Upstream has switched to gtk4. Adapted dependencies.
Created attachment 767078 [details] celluloid-9999.ebuild universal universal, should also work for releases emerge and run tested Adapted dependencies. Upstream git now depends on gui-libs/libadwaita. Please use this also as celluloid-0.23.ebuild
Created attachment 832203 [details] celluloid-9999.ebuild universal added changes from https://gitweb.gentoo.org/repo/gentoo.git/commit/media-video/celluloid?id=2a17d5c70ddfbb51076f38ec74972f47148dfcc9 Please use this also as celluloid-0.24.ebuild
https://github.com/celluloid-player/celluloid/releases/tag/v0.24
Ping everybody
Also, see https://github.com/gentoo/gentoo/pull/27487
*** Bug 871936 has been marked as a duplicate of this bug. ***
0.25 is here [1] (when you are implementing it, take a look at [2]). [1]: https://github.com/celluloid-player/celluloid/releases/tag/v0.25 [2]: https://github.com/celluloid-player/celluloid/commit/df3ae8b5a35f90e01df22343687d6be362799b26
jospezial, thanks! But patch is not -9999 nor -0.25 (at least, at gui-libs/libadwaita dependency). Also, edit, please, "See also": it should be a PR with @Elserjo's version of patch instead of my comment explicit. Thanks!
As a reminder, celluloid package in Gentoo is up for grabs or for co-maintainership. I can't get to it optimistically before a month or so, realistically longer, sorry.
0.26 is here [1] (when you are implementing it, take a look at [2]). [1]: https://github.com/celluloid-player/celluloid/releases/tag/v0.25 [2]: https://github.com/celluloid-player/celluloid/commit/df3ae8b5a35f90e01df22343687d6be362799b26
Opps, have posted wrong link above. Correct is: https://github.com/celluloid-player/celluloid/releases/tag/v0.26 BTW, could anybody post "up for grabs e-mail" in #gentoo-dev ?
I already did that back in June with no reaction. The only archive I was able to quickly find with that message is at http://archive.lwn.net:8080/gentoo-dev/cdddbb8f0db89ccdc02f7a2f0a823252cc29ea88.camel@gentoo.org/T/#u I'll be back in action to some extent within a week or two as well, if things go well.
It's been a while and Celluloid 0.26 was released. I built it and it seems to work just fine on my GNOME system. Any updates on potential maintainers?
Created attachment 885852 [details] celluloid-9999.ebuild universal updated to >=gui-libs/libadwaita-1.2.0 , year
(In reply to jospezial from comment #15) > Created attachment 885852 [details] > celluloid-9999.ebuild universal > > updated to >=gui-libs/libadwaita-1.2.0 , year Thanks! 1. Indents are omitted at lines 12, 13. 2. Is `>=gui-libs/libadwaita-1.2.0` build dep only?
> 2. Is `>=gui-libs/libadwaita-1.2.0` build dep only? I don't know how to decide that other than uninstalling that dep and check if celluloid still runs. Should I copy or move the line to RDEPEND or DEPEND?
> Should I copy or move the line to RDEPEND or DEPEND? To RDEPEND in your file (and it will come in both as per the next line). (I follow https://packages.gentoo.org/packages/gui-libs/libadwaita/reverse-dependencies .)
Created attachment 886228 [details] celluloid-9999.ebuild universal https://github.com/celluloid-player/celluloid/blob/b8aa41deb7ad7f0e24ac705dd846f7c7cb443e50/README.md?plain=1#L13 Program appstream-util found: YES (/usr/bin/appstream-util) added dev-libs/appstream-glib to BDEPEND The compile phase has -I/usr/include/appstream . But that would be dev-libs/appstream. The include maybe comes from libadwaita? Moved libadwaita to RDEPEND.
Great!
Oh, sorry, not great. Wee need `dev-util/gdbus-codegen` in BDEPEND.
jospezial, update the ebuild, please. Thanks!
Created attachment 886566 [details] celluloid-9999.ebuild universal dev-util/gdbus-codegen in BDEPEND I have some questions. https://github.com/celluloid-player/celluloid/blob/b8aa41deb7ad7f0e24ac705dd846f7c7cb443e50/src/meson.build#L130 Library m found: YES What is "m"? Program desktop-file-validate found: YES (/usr/bin/desktop-file-validate) Belongs to dev-util/desktop-file-utils. https://packages.gentoo.org/packages/dev-util/desktop-file-utils/reverse-dependencies With EAPI7 xdg.eclass adds dev-util/desktop-file-utils and x11-misc/shared-mime-info to IDEPEND. Not with EAPI8. I have added IDEPEND="dev-util/desktop-file-utils" to the ebuild. Don't know if that is right or something missing. But it is in the EAPI8 example at https://devmanual.gentoo.org/ebuild-writing/eapi/index.html By the way, I found that https://github.com/celluloid-player/celluloid/tree/master has a meson.build in almost every subdir. That could be the cause for the missing deps of the gentoo ebuild in all these years.
Library "m" is probably just libm.so.6, provided by libc. Without desktop-file-utils: ... Program desktop-file-validate found: NO ... It then proceeds to build and run just fine. Without shared-mime-info, on the other hand: Run-time dependency gtk4 found: NO (tried cmake) src/meson.build:51:9: ERROR: Dependency lookup for gtk4 with method 'pkgconfig' failed: Could not generate cflags for gtk4: Package shared-mime-info was not found in the pkg-config search path. Perhaps you should add the directory containing `shared-mime-info.pc' to the PKG_CONFIG_PATH environment variable Package 'shared-mime-info', required by 'gdk-pixbuf-2.0', not found desktop-file-utils does not pull in shared-mime-info, so it should be declared as an additional dependency.
Actually, never mind. shared-mime-info is pulled in by gtk4 anyways and I'm just dumb.
Created attachment 889508 [details] celluloid-0.26.ebuild I am using this ebuild locally for now. A few notes compared with the posted 9999 ebuild: - I kept the project description from upstream at https://github.com/celluloid-player/celluloid/ (i.e. no "GTK4" versioning) - I dropped the IDEPEND as, supposedly, all that should be handled by the xdg.eclass in the right way
Pacho, thanks! Should be `>=dev-libs/glib-2.66:2`, [1]. P.S. New description :D [2] --- 1: https://github.com/celluloid-player/celluloid/blob/v0.26/README.md?plain=1#L14 2: https://github.com/celluloid-player/celluloid/commit/6c2b83e8318fb4383ed5f9da3108aae1bf374d12
Created attachment 890439 [details] celluloid-0.26.ebuild You are right, supposedly it could work with 2.44 but it's passing -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_66 :/ I updated the description too (even if I feel it a bit "too general")
(In reply to Pacho Ramos from comment #28) > Created attachment 890439 [details] > celluloid-0.26.ebuild > > You are right, supposedly it could work with 2.44 but it's passing > -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_66 :/ > > I updated the description too (even if I feel it a bit "too general") @Mart, are you ok with me committing this? If ok, should I close this bug or do you want to keep it for eventually adding a live version (as stated in bug summary)? Thanks
