Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768729 - gui-libs/display-manager-init improvements
Summary: gui-libs/display-manager-init improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-04 23:11 UTC by William Hubbs
Modified: 2022-10-09 22:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
display-manager-init.patch (display-manager-init.patch,7.00 KB, patch)
2021-02-04 23:12 UTC, William Hubbs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2021-02-04 23:11:38 UTC
Hi,

this patch reworks display-manager-init to take advantage of OpenRC
internal features.

Specifically, you should be using the default start() and stop()
functions of OpenRC.

This simplifies your code a bit because it can now levarage the
command/command_background/start_stop_daemon_args variables.

Also, the startDM script that goes in /usr/bin now just calls rc-service
to start/stop the display manager.
Comment 1 William Hubbs gentoo-dev 2021-02-04 23:12:17 UTC
Created attachment 685812 [details, diff]
display-manager-init.patch

Here is the patch.

Thanks,

William
Comment 2 Piotr Karbowski (RETIRED) gentoo-dev 2022-07-02 20:39:14 UTC
I will be looking into adding some of those.
Comment 3 Larry the Git Cow gentoo-dev 2022-10-09 22:10:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=856c7ecf226fcd8803d3e144a0ec97291de87a18

commit 856c7ecf226fcd8803d3e144a0ec97291de87a18
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2022-10-09 22:08:58 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2022-10-09 22:10:32 +0000

    gui-libs/display-manager-init: 1.1 version bump
    
    Following WilliamH suggestion, the init has been redone in a
    openrc-friendly way, along with little cleanup and restore
    support for nox boot parameter, since nox were with us since
    always, good to still support it alongside nogui one.
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=774189
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=768729
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 .../display-manager-init-1.1.ebuild                |  54 ++++++
 .../files/display-manager-setup.initd-r1           |  13 ++
 .../files/display-manager.initd-r3                 | 201 +++++++++++++++++++++
 3 files changed, 268 insertions(+)