Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768663 - media-gfx/inkscape: hard-depends on x11-libs/libX11 while it's a soft-dependency
Summary: media-gfx/inkscape: hard-depends on x11-libs/libX11 while it's a soft-dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-02-04 17:39 UTC by Haelwenn (lanodan) Monnier
Modified: 2022-05-26 02:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Haelwenn (lanodan) Monnier 2021-02-04 17:39:55 UTC
Not sure how to fix it since it's an optional dependency (see `CMakeScripts/DefineDependsandFlags.cmake:388`), maybe simply removing x11-libs/libX11 in the ebuild works since it should only be linked if it's present and doesn't seems to have stuff like "-DHAVE_X11" so shouldn't require a rebuild?

And otherwise I guess using `X? ( x11-libs/libX11 )` doesn't works so well without patching the CMakeFile to make sure it doesn't ends up linking it when USE=-X is set but libX11 is present.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-02-04 23:06:22 UTC
Gave it a quick try with 1.0.2 and does (at least) build on a libX11-less system (both without and with most USE enabled, except dia given that indirectly pulls libX11).

Not convinced linking with X11 is ever really needed even for X11. The gui didn't open on X11 anymore but it's expected if removed support from gtk+:3 and everything else, not that I've tested much more.
Comment 2 Larry the Git Cow gentoo-dev 2022-05-26 01:12:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6873fa9fe5ae8d9e3057f4d4d1204ff2e40122f

commit e6873fa9fe5ae8d9e3057f4d4d1204ff2e40122f
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2021-03-29 15:49:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-26 01:10:45 +0000

    media-gfx/inkscape: Fix automagic dependency on libX11
    
    Related: https://gitlab.com/inkscape/inkscape/-/merge_requests/3208
    Closes: https://bugs.gentoo.org/768663
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
    Closes: https://github.com/gentoo/gentoo/pull/20181
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/inkscape-1.0.2-automagic-libX11.patch    | 181 +++++++++++++++++++
 media-gfx/inkscape/inkscape-1.1.2-r2.ebuild        | 191 +++++++++++++++++++++
 media-gfx/inkscape/inkscape-9999.ebuild            |   7 +-
 3 files changed, 376 insertions(+), 3 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2022-05-26 02:47:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9951345352e2afdb9832c31657a38a19b00a9b52

commit 9951345352e2afdb9832c31657a38a19b00a9b52
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-26 02:23:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-26 02:47:04 +0000

    media-gfx/inkscape: fixup X11 patch
    
    Bug: https://github.com/gentoo/gentoo/pull/20181
    Closes: https://bugs.gentoo.org/768663
    Signed-off-by: Sam James <sam@gentoo.org>

 ...patch => inkscape-1.1.2-automagic-libX11.patch} | 41 +++++++---------------
 media-gfx/inkscape/inkscape-1.1.2-r2.ebuild        |  2 +-
 2 files changed, 14 insertions(+), 29 deletions(-)