Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768468 - app-emulation/xen-tools-4.14.1 with gcc-11: linux.c:165:50: error: argument 7 of type ‘const xen_pfn_t[]’ {aka ‘const long unsigned int[]’} declared as an ordinary array [-Werror=vla-parameter]
Summary: app-emulation/xen-tools-4.14.1 with gcc-11: linux.c:165:50: error: argument 7...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords: PullRequest
: 786294 787215 (view as bug list)
Depends on:
Blocks: gcc-11
  Show dependency tree
 
Reported: 2021-02-03 09:43 UTC by Kobboi
Modified: 2021-05-11 15:47 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,128.30 KB, text/plain)
2021-02-03 09:44 UTC, Kobboi 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2021-02-03 09:43:15 UTC 
x86_64-pc-linux-gnu-gcc  -DPIC  -fno-strict-overflow -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .subdirs-all.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .subdir-all-libs.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .subdirs-all.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .subdir-all-foreignmemory.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .build.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror -Wmissing-prototypes -I./include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include  -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/libs/toollog/include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include  -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/libs/toolcore/include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .linux.opic.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror -Wmissing-prototypes -I./include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include  -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/libs/toollog/include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include  -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/libs/toolcore/include -I/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/include  -fPIC -c -o linux.opic linux.c 
mkdir -p /var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/pkg-config
mv headers.chk.new headers.chk
linux.c:165:50: error: argument 7 of type ‘const xen_pfn_t[]’ {aka ‘const long unsigned int[]’} declared as an ordinary array [-Werror=vla-parameter]
  165 |                                  const xen_pfn_t arr[/*num*/], int err[/*num*/])
      |                                  ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
In file included from linux.c:29:
private.h:35:50: note: previously declared as a variable length array ‘const xen_pfn_t[num]’ {aka ‘const long unsigned int[num]’}
   35 |                                  const xen_pfn_t arr[num], int err[num]);
      |                                  ~~~~~~~~~~~~~~~~^~~~~~~~
linux.c:165:68: error: argument 8 of type ‘int[]’ declared as an ordinary array [-Werror=vla-parameter]
  165 |                                  const xen_pfn_t arr[/*num*/], int err[/*num*/])
      |                                                                ~~~~^~~~~~~~~~~~
In file included from linux.c:29:
private.h:35:64: note: previously declared as a variable length array ‘int[num]’
   35 |                                  const xen_pfn_t arr[num], int err[num]);
      |                                                            ~~~~^~~~~~~~
linux.c:165:50: error: argument 7 of type ‘const xen_pfn_t[]’ {aka ‘const long unsigned int[]’} declared as an ordinary array [-Werror=vla-parameter]
  165 |                                  const xen_pfn_t arr[/*num*/], int err[/*num*/])
      |                                  ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
In file included from linux.c:29:
private.h:35:50: note: previously declared as a variable length array ‘const xen_pfn_t[num]’ {aka ‘const long unsigned int[num]’}
   35 |                                  const xen_pfn_t arr[num], int err[num]);
      |                                  ~~~~~~~~~~~~~~~~^~~~~~~~
linux.c:165:68: error: argument 8 of type ‘int[]’ declared as an ordinary array [-Werror=vla-parameter]
  165 |                                  const xen_pfn_t arr[/*num*/], int err[/*num*/])
      |                                                                ~~~~^~~~~~~~~~~~
In file included from linux.c:29:
private.h:35:64: note: previously declared as a variable length array ‘int[num]’
   35 |                                  const xen_pfn_t arr[num], int err[num]);
      |                                                            ~~~~^~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/Rules.mk:216: linux.o] Error 1
make[6]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[6]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/Rules.mk:213: linux.opic] Error 1
make[6]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory'
make[5]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory/../../../tools/libs/libs.mk:45: build] Error 2
make[5]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/foreignmemory'
make[4]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/../../tools/Rules.mk:240: subdir-all-foreignmemory] Error 2
make[4]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs'
make[3]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs/../../tools/Rules.mk:235: subdirs-all] Error 2
make[3]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/libs'
make[2]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/../tools/Rules.mk:240: subdir-all-libs] Error 2
make[2]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools'
make[1]: *** [/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools/../tools/Rules.mk:235: subdirs-all] Error 2
make[1]: Leaving directory '/var/tmp/portage/app-emulation/xen-tools-4.14.0-r5/work/xen-4.14.0/tools'
make: *** [Makefile:63: build-tools] Error 2


Reproducible: Always
Comment 1 Kobboi 2021-02-03 09:43:40 UTC 
Portage 3.0.14 (python 3.8.7-final-0, !../../var/db/repos/kobboi-linux/profiles/kobboi/samsonov, gcc-11.0.0, glibc-2.32-r7, 5.4.93 x86_64)
=================================================================
System uname: Linux-5.4.93-x86_64-Intel-R-_Core-TM-_i7-6700_CPU_@_3.40GHz-with-glibc2.2.5
KiB Mem:    32776900 total,   1957364 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Tue, 02 Feb 2021 16:47:41 +0000
Head commit of repository gentoo: 28b00689302043f98629d66bf24dc6293135f7e2

Timestamp of repository brother-overlay: Sat, 23 Jan 2021 10:41:31 +0000
Head commit of repository brother-overlay: fe35aa6732459e8430d9b65f4ef6782d4dd5dde9

Timestamp of repository gitlab: Wed, 27 Jan 2021 16:32:34 +0000
Head commit of repository gitlab: f003d9ba47a403085e2c15bf64f9575493188310

Head commit of repository kobboi-linux: 558c07acd2347251a904c9c5f61655f5822101eb

Timestamp of repository steam-overlay: Sat, 23 Jan 2021 10:41:07 +0000
Head commit of repository steam-overlay: d4fc70b86dcf24462ef302663199c26de4be50cd

sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
ccache version 4.1 [disabled]
app-shells/bash:          5.1_p4::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.32.0-r1::gentoo
dev-lang/python:          2.7.18-r6::gentoo, 3.7.9-r2::gentoo, 3.8.7-r1::gentoo, 3.9.1-r1::gentoo
dev-util/ccache:          4.1::gentoo
dev-util/cmake:           3.19.4::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.15.1-r2::gentoo, 1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            9.3.0-r2::gentoo, 10.2.0-r5::gentoo, 11.0.0_pre9999::gentoo
sys-devel/gcc-config:     2.3.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

brother-overlay
    location: /var/db/repos/brother-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/brother-overlay.git
    masters: gentoo

gitlab
    location: /var/db/repos/gitlab
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gitlab.git
    masters: gentoo

kobboi-linux
    location: /var/db/repos/kobboi-linux
    sync-type: git
    sync-uri: https://github.com/kobboi/kobboi-linux.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

Installed sets: @kobboi-all
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=x86-64 -pipe -fomit-frame-pointer -g -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.6/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.4/ext-active/ /etc/php/apache2-php8.0/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=x86-64 -pipe -fomit-frame-pointer -g -ggdb"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles installsources ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://kobboi-linux:*password*@10.8.0.1/2020.11"
INSTALL_MASK="/usr/src/debug /usr/lib/debug"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_BINHOST="ftp://kobboi-linux:*password*@10.8.0.1/2020.11/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 avahi berkdb bluetooth bzip2 cairo cdda cdr cli colord crypt cups dbus dist-kernel djvu dri dts dvd dvdr eds egl emboss encode evo exif facedetect ffmpeg flac fluidsynth fortran frei0r gdbm gif glade gles gles2 gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gtk3 gtkstyle gui iconv icu introspection ipv6 jpeg ladspa lcms libass libglvnd libnotify libsecret libtirpc lv2 lz4 lzma lzo mad midi mng modemmanager mono mp3 mp4 mpeg mtp multilib nautilus ncurses networkmanager nls nptl ogg opencv opengl openmp opus pam pango pcre pdf png policykit ppds pulseaudio qt5 readline samba screencast sdl seccomp smartcard smp spell split-usr ssl startup-notification svg sysprof systemd tcpd tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vorbis wayland wxwidgets x264 xattr xcb xml xv xvid zeroconf zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="hda-intel ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse synaptics libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="vesa radeon nvidia intel amdgpu dummy fbdev nouveau radeonsi v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Kobboi 2021-02-03 09:44:07 UTC 
Created attachment 685608 [details]
build.log
Comment 3 Kobboi 2021-02-03 09:44:28 UTC 
Compiles fine with gcc-10.2
Comment 4 Kobboi 2021-02-19 09:12:04 UTC 
Updated for 4.14.1 (issue still present)
Comment 5 Tomáš Mózes 2021-02-19 15:08:31 UTC 
Can you please apply https://src.fedoraproject.org/rpms/xen/blob/rawhide/f/xen.gcc11.fixes.patch ?
Comment 6 Tomáš Mózes 2021-02-19 15:10:06 UTC 
I meant if you can test with these patches. I don't have gcc-11 locally yet.
Comment 7 Kobboi 2021-02-19 15:48:46 UTC 
4.14.1 fails on tests/bigint_test.c:232:14: error: ‘result_raw’ may be used uninitialized [-Werror=maybe-uninitialized]

I have reverted 5ed877f82c57f438fefcce51ccc6029fb24d1294 and applied the same patch to 4.14.0-r5. Same error.
Comment 8 Tomáš Mózes 2021-04-30 15:03:20 UTC 
*** Bug 786294 has been marked as a duplicate of this bug. ***
Comment 9 Tomáš Mózes 2021-04-30 21:28:00 UTC 
*** Bug 787215 has been marked as a duplicate of this bug. ***
Comment 10 Jiří Moravec 2021-05-07 19:23:20 UTC 
xen-tools-4.14.1-r2 build with fedora patch was successful. Thank you.
Comment 11 Tomáš Mózes 2021-05-07 20:08:07 UTC 
4.14.2 / 4.15.0 from the PR should work without additional patches, if you could test it would help.
Comment 12 Larry the Git Cow gentoo-dev 2021-05-11 15:47:39 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76c79a20941443d30d858a8c9a2668dc50574f04

commit 76c79a20941443d30d858a8c9a2668dc50574f04
Author:     Tomáš Mózes <hydrapolic@gmail.com>
AuthorDate: 2021-04-30 20:20:04 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-05-11 15:47:32 +0000

    app-emulation/xen-tools: bump to 4.15.0
    
    Closes: https://bugs.gentoo.org/732970
    Closes: https://bugs.gentoo.org/768468
    Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 app-emulation/xen-tools/Manifest                  |   5 +
 app-emulation/xen-tools/files/gentoo-patches.conf |  14 +
 app-emulation/xen-tools/xen-tools-4.15.0.ebuild   | 532 ++++++++++++++++++++++
 3 files changed, 551 insertions(+)