With the latest media-tv/kodi-19.0_rc1-r2 ebuild, Gentoo added cdio flag so in a way to make dev-libs/libcdio features optional. Possibly due to I'm building kodi with dvd flag enabled, compilation fails if libcdio is not installed. Likely next line should be added to COMMON_DEPEND section of the ebuild dvd? ( dev-libs/libcdio ) Reproducible: Always Steps to Reproduce: Remove libcdio package and try to compile kodi with cdio flag disabled. Actual Results: Compilation complains/stop about missing libcdio.h at very beginning of compile phase. Full use flags I'm using for this package is ... [ebuild R ] media-tv/kodi-19.0_rc1-r2::gentoo USE="X alsa cdio css dbus dvd gles lcms pulseaudio (system-ffmpeg) udisks upnp upower xslt -airplay -bluetooth -bluray -caps -cec -dav1d -gbm (-libressl) -libusb -lirc -mariadb -mysql -nfs -opengl -power-control (-raspberry-pi) -samba -test -udev -udf -vaapi -vdpau -wayland -webserver -zeroconf" CPU_FLAGS_X86="avx sse sse2 sse3 sse4_1 sse4_2 -avx2" PYTHON_SINGLE_TARGET="python3_9 -python3_7 -python3_8" 0 KiB
Created attachment 685494 [details] build.log + emerge --info.txt Please include full build.log and emerge --info when reporting a build failure next time. But I can reproduce (regardless of USE=dvd), if not misunderstanding appears set as a hard dependency in CMakeLists.txt: # Required dependencies. Keep in alphabetical order please set(required_deps ASS Cdio ...
Karlson2k, can you please take a look? I believe https://github.com/gentoo/gentoo/commit/0873ae4038ab53d3372c66ec5adae1f4e585d03c#diff-3ed70bc38fedb0a2276b513eebd8560ab0c63a775d88ca635e834e98e099a829 introduced this issue.
Yes, this patch introduced the problem. However libcdio isn't a hard dependency and I have tested build without it. I'll check dependencies relationship.
I was able to build Kodi only with USE="X gl". I will investigate deeper.
Yes, the problem is in Kodi cmake files. It ignore the setting and search for the lib. Confirmed. The patch is coming.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c306a9a2732eeb192c0fc994a91f6753279138a commit 7c306a9a2732eeb192c0fc994a91f6753279138a Author: Karlson2k (Evgeny Grin) <k2k@narod.ru> AuthorDate: 2021-02-02 19:14:04 +0000 Commit: Craig Andrews <candrews@gentoo.org> CommitDate: 2021-02-02 19:37:15 +0000 media-tv/kodi: marked libcdio is required dependency Kodi build system ignores user settings for libcdio. Closes: https://bugs.gentoo.org/768294 Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru> Closes: https://github.com/gentoo/gentoo/pull/19309 Signed-off-by: Craig Andrews <candrews@gentoo.org> media-tv/kodi/kodi-19.0_rc1-r2.ebuild | 6 +++--- media-tv/kodi/kodi-19.9999.ebuild | 6 +++--- media-tv/kodi/kodi-9999.ebuild | 6 +++--- media-tv/kodi/metadata.xml | 1 - 4 files changed, 9 insertions(+), 10 deletions(-)
