Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768135 - >=sys-apps/grep-3.5: fails 'stack-overflow' test on sparc
Summary: >=sys-apps/grep-3.5: fails 'stack-overflow' test on sparc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://lists.gnu.org/archive/html/bu...
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks: 753638
  Show dependency tree
 
Reported: 2021-02-01 03:23 UTC by Sam James
Modified: 2021-07-24 23:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_768135.txt,215.07 KB, text/plain)
2021-02-01 03:23 UTC, Sam James
Details
test-suite.log (file_768135.txt,98.73 KB, text/plain)
2021-02-01 03:24 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-01 03:23:41 UTC
Created attachment 685353 [details]
build.log

Doesn't fail:
=sys-apps/grep-3.4

Fails:
=sys-apps/grep-3.5
=sys-apps/grep-3.6

----
stack-overflow: failed test: grep never printed "stack overflow"
FAIL: stack-overflow

----
Portage 3.0.13 (python 3.7.9-final-0, default/linux/sparc/17.0/64ul/desktop, gcc-9.3.0, glibc-2.32-r6, 5.9.6-gentoo sparc)
=================================================================
System uname: Linux-5.9.6-gentoo-sparc-sun4v-with-gentoo-2.7
KiB Mem:   531351440 total, 452139736 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 01 Feb 2021 02:55:15 +0000
sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
app-shells/bash:          5.0_p18::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r6::gentoo, 3.7.9-r2::gentoo, 3.8.7-r1::gentoo, 3.9.1-r1::gentoo
dev-util/cmake:           3.17.4-r1::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            9.3.0-r2::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r6::gentoo
Repositories:

gentoo
    location: /bound/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="@FREE"
CBUILD="sparc64-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=ultrasparc -pipe -fdiagnostics-show-option -frecord-gcc-switches"
CHOST="sparc64-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -mcpu=ultrasparc -pipe"
DISTDIR="/bound/distfiles"
EMERGE_DEFAULT_OPTS="--complete-graph --with-bdeps=y --keep-going --deep"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -mcpu=ultrasparc -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -mcpu=ultrasparc -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j100 -l257"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl alsa berkdb big-endian branding bzip2 cairo cdda cdr cli crypt cups dbus dri dts dvd dvdr elogind emboss encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds readline sdl sparc spell split-usr ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zlib" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8 python3_7 python3_9" RUBY_TARGETS="ruby25 ruby26" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-01 03:24:14 UTC
Created attachment 685356 [details]
test-suite.log
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-01 04:36:41 UTC
Reported upstream but not yet in the archives, will link when it's there.

(gdb) r
Starting program: /var/tmp/portage/sys-apps/grep-3.6/work/grep-3.6/src/grep -E -f in
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x0000010000026908 in peek_token (token=0x10000aa9f30, input=0x10000aa9f30, syntax=1099522809648) at regcomp.c:1784
1784    {
(gdb) bt
#0  0x0000010000026908 in peek_token (token=0x10000aa9f30, input=0x10000aa9f30, syntax=1099522809648) at regcomp.c:1784
#1  0x0000010000aa9f38 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)

regcomp.c is in gnulib. gnulib's corresponding test fails too:

# ./test-c-stack
test-c-stack: program error
Segmentation fault (core dumped)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-05 22:03:37 UTC
(In reply to Sam James from comment #2)
> 
> regcomp.c is in gnulib. gnulib's corresponding test fails too:
> 
> # ./test-c-stack
> test-c-stack: program error
> Segmentation fault (core dumped)

Given this, the upstream maintainers naturally said to pass it on to gnulib. Done here: https://lists.gnu.org/archive/html/bug-gnulib/2021-02/msg00002.html.
Comment 4 Larry the Git Cow gentoo-dev 2021-03-22 08:59:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c56995f410c33050133c71a45da78f4d3ee9868

commit 9c56995f410c33050133c71a45da78f4d3ee9868
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-03-19 22:11:14 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-03-22 08:57:42 +0000

    sys-apps/grep: use dev-libs/libsigsegv for stack overflow handling on sparc
    
    This fixes test failures on sparc in grep 3.6, although 3.5 still fails.
    (This seems to be because of an older copy of gnulib in that version.)
    
    It seems too risky to to backport gnulib changes to grep 3.5.
    
    [Note that I ended up discovering an independent issue because filename-lineno.pl
    failed on sparc too. This ended up being a real bug in that libpcre upstream
    doesn't support JIT on sparc64 which manifested in both the test failing and
    e.g. grep -P foo dying with SIGBUS.
    
    I've therefore masked dev-libs/libpcre[jit] on sparc64 in fd573f4.]
    
    URL: https://lists.gnu.org/archive/html/bug-gnulib/2021-02/msg00002.html
    URL: https://debbugs.gnu.org/46227
    Bug: https://bugs.gentoo.org/673524
    Closes: https://bugs.gentoo.org/768135
    Signed-off-by: Sam James <sam@gentoo.org>
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/grep/grep-3.5.ebuild | 15 ++++++++++++---
 sys-apps/grep/grep-3.6.ebuild | 15 ++++++++++++---
 2 files changed, 24 insertions(+), 6 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb99c571a3f0c15a69a586b85832f5d5b115718c

commit bb99c571a3f0c15a69a586b85832f5d5b115718c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-03-19 23:24:25 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-03-22 08:57:43 +0000

    profiles/arch/sparc: mask sys-apps/grep[static] for now
    
    dev-libs/libsigsegv lacks USE=static-libs and there's really
    no pressing need to add it for now. Let's just disable USE=static
    for grep on sparc for the time being.
    
    Bug: https://bugs.gentoo.org/768135
    Signed-off-by: Sam James <sam@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/20012
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 profiles/arch/sparc/package.use.mask | 9 +++++++++
 1 file changed, 9 insertions(+)