Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767760 - media-sound/musescore-3.6.1 fails to compile
Summary: media-sound/musescore-3.6.1 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-28 13:47 UTC by Agostino Sarubbo
Modified: 2021-02-28 11:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,50.25 KB, application/x-xz)
2021-01-28 13:47 UTC, Agostino Sarubbo
Details
musescore-3.6.1-rename-audioitem.patch (musescore-3.6.1-rename-audioitem.patch,491 bytes, patch)
2021-02-28 10:50 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-01-28 13:47:14 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/musescore-3.6.1 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2021-01-28 13:47:17 UTC
Created attachment 684972 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2021-01-28 13:47:18 UTC
Possible context of error(s):

/var/tmp/portage/media-sound/musescore-3.6.1/work/MuseScore-3.6.1/mscore/exportdialog.cpp:79:25: error: ‘audioItem’ was not declared in this scope
Comment 3 Ionen Wolkens gentoo-dev 2021-01-28 15:18:38 UTC
Getting the same with USE=-mp3, fine if enabled.
Comment 4 Miroslav Šulc gentoo-dev 2021-02-28 09:17:19 UTC
thanks for the report and for the hint with the use flag. i was able to reproduce the issue, both with 3.6.1 and 3.6.2. 9999 does not have this issue, anyway i do not have enough time to find the appropriate commit that fixes the issue.

Ionen, if you would be so kind, could you have a look at it? currently it's holding me back from stabilizing 3.6.1 and later 3.6.2 aswell, unless we'll be able to fix this.
Comment 5 Ionen Wolkens gentoo-dev 2021-02-28 10:50:37 UTC
Created attachment 688692 [details, diff]
musescore-3.6.1-rename-audioitem.patch

Honestly having a hard time to make sense of upstream, this code never existed in master and it even removed the mscore/ directory entirely (exists in the 3.6.1 branch).

That aside, just looks like a case of badly copy/pasted code with a variable that wasn't renamed. Trivial so here's my own patch, tested and successfully makes "MP3 Audio" grey'ed out in the export dialog with -mp3.
Comment 6 Miroslav Šulc gentoo-dev 2021-02-28 11:44:32 UTC
Ionen, cool, as always ;-) thank!
Comment 7 Larry the Git Cow gentoo-dev 2021-02-28 11:47:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c0d85046b22c455258b27c65c2d34537a13d87

commit 21c0d85046b22c455258b27c65c2d34537a13d87
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2021-02-28 11:46:45 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2021-02-28 11:47:08 +0000

    media-sound/musescore: fixed compilation with -mp3
    
    thanks to Ionen Wolkens <sudinave@gmail.com> for the patch
    
    Closes: https://bugs.gentoo.org/767760
    Package-Manager: Portage-3.0.16, Repoman-3.0.2
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../musescore/files/musescore-3.6.1-rename-audioitem.patch   | 12 ++++++++++++
 media-sound/musescore/musescore-3.6.1.ebuild                 |  1 +
 media-sound/musescore/musescore-3.6.2.ebuild                 |  1 +
 3 files changed, 14 insertions(+)