Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767469 - dev-libs/pegtl-2.8.3-r1 undelete to fix sys-apps/usbguard installation? (was: sys-apps/usbguard-1.0.0 fails to compile: configure: error: in /.../usbguard-1.0.0:)
Summary: dev-libs/pegtl-2.8.3-r1 undelete to fix sys-apps/usbguard installation? (was:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Seifert
URL: https://github.com/USBGuard/usbguard/...
Whiteboard:
Keywords:
: 768090 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-27 17:16 UTC by Toralf Förster
Modified: 2021-02-08 13:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.62 KB, text/plain)
2021-01-27 17:16 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,182.07 KB, text/plain)
2021-01-27 17:16 UTC, Toralf Förster
Details
environment (environment,22.17 KB, text/plain)
2021-01-27 17:16 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,16.34 KB, application/x-bzip)
2021-01-27 17:16 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,15.66 KB, application/x-bzip)
2021-01-27 17:16 UTC, Toralf Förster
Details
sys-apps:usbguard-1.0.0:20210127-165653.log (sys-apps:usbguard-1.0.0:20210127-165653.log,10.30 KB, text/plain)
2021-01-27 17:16 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,9.68 KB, application/x-bzip)
2021-01-27 17:16 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-01-27 17:16:03 UTC
configure: WARNING:     ## ------------------------------------ ##
checking for tao/pegtl.hpp... no
configure: error: in `/var/tmp/portage/sys-apps/usbguard-1.0.0/work/usbguard-1.0.0':
configure: error: PEGTL header file not found or not usable. Re-run with --with-bundled-pegtl to use the bundled library.
See `config.log' for more details


  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-20210123-232713

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.0.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.0.1
Python 3.8.7
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.48.0 *
The Glorious Glasgow Haskell Compilation System, version 8.8.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Wed Jan 27 15:32:35 UTC 2021

emerge -qpvO sys-apps/usbguard
[ebuild  N    ] sys-apps/usbguard-1.0.0  USE="systemd -bash-completion -dbus -ldap -policykit -static-libs"
Comment 1 Toralf Förster gentoo-dev 2021-01-27 17:16:04 UTC
Created attachment 684867 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-01-27 17:16:06 UTC
Created attachment 684870 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-01-27 17:16:07 UTC
Created attachment 684873 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-01-27 17:16:08 UTC
Created attachment 684876 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-01-27 17:16:09 UTC
Created attachment 684879 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-01-27 17:16:11 UTC
Created attachment 684882 [details]
sys-apps:usbguard-1.0.0:20210127-165653.log
Comment 7 Toralf Förster gentoo-dev 2021-01-27 17:16:12 UTC
Created attachment 684885 [details]
temp.tar.bz2
Comment 8 Sebastian Pipping gentoo-dev 2021-01-31 17:07:19 UTC
Hello @sci team,

sys-apps/usbguard uses dev-libs/pegtl and as shown here does not compile with 3.2.0 while 2.8.3-r1 seemed to work fine.  Now you have deleted from 2.8.3-r1 the tree recently (which I don't blame anyone for, the dependency tree said it's okay).  sys-apps/usbguard comes with a bundle of an older version of pegtl but we want to keep things unbundled e.g. for security, in general, ideally.  With that in mind: How do you feel about this suggestion (case "A"):

- We restore dev-libs/pegtl-2.8.3-r1 from Git history
- I open a bug for compatibility with pegtl 3.2.0 upstream
- I make usbguard depend on <dev-libs/pegtl-3 while we wait for a release with compatibility

The alternative would be (case "B"):

- I make sys-apps/usbguard use the bundled copy of pegtl 2.8.3
- I open a bug for compatibility with pegtl 3.2.0 upstream
- I turn this ticket into a task about unbundling pegtl
- I unbundle pegtl once we have a new release with compatibility

Please let me know what you prefer here.  In case I don't hear back for a while, I'll go for "B" which is not my favorite to restore compilation in a way that respects your authority on dev-libs/pegtl.

Let me know what you think (and feel free to assign back to me when we have a decision).

Thanks and best, Sebastian
Comment 9 Sebastian Pipping gentoo-dev 2021-01-31 18:34:05 UTC
*** Bug 768090 has been marked as a duplicate of this bug. ***
Comment 10 Sebastian Pipping gentoo-dev 2021-02-02 17:12:53 UTC
David, assigning to you know for https://github.com/gentoo/gentoo/commit/dcae9821c0407c24b887bf1f5f77b8392cd04757 .  An objections to me restoring pegtl 2.8.3?  Please see the comment above for why/context and other options.  Thank you!
Comment 11 Larry the Git Cow gentoo-dev 2021-02-08 13:39:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a14e7a0b5bafc69498ccaeecdb4ca366b8fb89e3

commit a14e7a0b5bafc69498ccaeecdb4ca366b8fb89e3
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2021-02-08 13:32:32 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2021-02-08 13:38:37 +0000

    sys-apps/usbguard: Fix dev-libs/pegtl dependency
    
    Closes: https://bugs.gentoo.org/767469
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.14, Repoman-3.0.2

 sys-apps/usbguard/usbguard-0.7.6-r1.ebuild | 4 ++--
 sys-apps/usbguard/usbguard-0.7.8.ebuild    | 2 +-
 sys-apps/usbguard/usbguard-1.0.0.ebuild    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=993785709e60121bbd41f2265f3413d2037aaba6

commit 993785709e60121bbd41f2265f3413d2037aaba6
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2021-02-08 13:29:05 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2021-02-08 13:38:33 +0000

    dev-libs/pegtl: Undelete pegtl-2.8.3-r1 for sys-apps/usbguard
    
    Bug: https://bugs.gentoo.org/767469
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.14, Repoman-3.0.2

 dev-libs/pegtl/Manifest                       |  1 +
 dev-libs/pegtl/files/pegtl-2.8.3-cmake.patch  | 29 ++++++++++++++++++
 dev-libs/pegtl/files/pegtl-2.8.3-gcc-10.patch | 43 +++++++++++++++++++++++++++
 dev-libs/pegtl/pegtl-2.8.3-r1.ebuild          | 32 ++++++++++++++++++++
 4 files changed, 105 insertions(+)
Comment 12 Sebastian Pipping gentoo-dev 2021-02-08 13:40:32 UTC
I needed to act here myself now to fix the build that has been broken for more than a week now.  I hope you're okay with the steps that I took, thanks for your understanding.