Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767424 - app-crypt/pinentry-1.1.1 - app-crypt/gcr needs +gtk to build pinentry-gnome3
Summary: app-crypt/pinentry-1.1.1 - app-crypt/gcr needs +gtk to build pinentry-gnome3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-27 09:59 UTC by Jonas Frei
Modified: 2021-08-29 15:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Frei 2021-01-27 09:59:07 UTC
If you build pinentry with "+gtk -gnome-keyring", I assumed that pinentry-gnome3 would be built. However, this was not the case. After some investigation it turned out that app-crypt/gcr needs the "+gtk" USE flag for pinentry-gnome3 to be built.

Therefore I propose that if app-crypt/pinentry uses +gtk, there should be a dependency for app-crypt/gcr +gtk
Comment 1 Balint SZENTE 2021-01-27 11:03:34 UTC
app-crypt/gcr must be also build dependency (instead of RDEDEND), because otherwise pinentry will disable `pinentry-gnome3` through it's ./configure if it's not found on system.

Happened to me at upgrade @world, because gcr was scheduled to build *after* pinentry.
Comment 2 yiqunding 2021-04-25 07:31:34 UTC
I had exactly the same issue.

Had to manually enable the "gtk" flag for "app-crypt/gcr", this way if I build pinentry with "+gtk", the pinentry-gnome3 would be built.
Comment 3 Raffaello D. Di Napoli 2021-05-17 06:18:28 UTC
+1

I noticed I lost the Gtk pinentry when rebuilding or upgrading app-crypt/pinentry-1.1.0-r4, and got it back by adding USE=gtk for app-crypt/gcr .

In RDEPEND,

  gtk? ( app-crypt/gcr )

should be

  gtk? ( app-crypt/gcr[gtk] )

or else configure will output something like this:

	Pinentry v1.1.0 has been configured as follows:

	Revision:    ()
	Platform:  x86_64-pc-linux-gnu

	Curses Pinentry ..: yes
	TTY Pinentry .....: yes
	Emacs Pinentry ...: no
	GTK+-2 Pinentry ..: no
	GNOME 3 Pinentry .: no
	Qt Pinentry ......: no 
	TQt Pinentry .....: no
	W32 Pinentry .....: no
	FLTK Pinentry ....: no

	Fallback to Curses: yes
	Emacs integration : yes

	libsecret ........: no

	Default Pinentry .: pinentry-curses

pinentry-1.1.1 has the same issue.

It’s also unsettling that pinentry’s configure quietly suppresses the GNOME 3 pinentry instead of failing because after all it was explicitly requested with  --enable-pinentry-gnome3 . This is like inverse automagic dependency: you ask for it, and if missing, it quietly ignores your request.
Comment 4 Larry the Git Cow gentoo-dev 2021-08-29 15:45:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ab4c223e063efc9db18982cc135b20d0b1f8da8

commit 6ab4c223e063efc9db18982cc135b20d0b1f8da8
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2021-08-29 15:44:58 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2021-08-29 15:44:58 +0000

    app-crypt/pinentry: fix gtk dependency
    
    Closes: https://bugs.gentoo.org/767424
    
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 app-crypt/pinentry/pinentry-1.1.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)