Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767286 - dev-util/kdevelop-5.6.1: plugin requires dev-util/indent
Summary: dev-util/kdevelop-5.6.1: plugin requires dev-util/indent
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-26 12:45 UTC by Vasiliy Yeremeyev
Modified: 2021-02-02 19:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vasiliy Yeremeyev 2021-01-26 12:45:52 UTC
kdevelop plugin tries to find indent at startup:

/bin/sh: line 1: indent: command not found
kdevelop.plugins.customscript: indent returned empty text for style "GNU_indent_GNU" "indent"

Maybe it is a good idea to add dev-util/indent to dependencies.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-01-26 13:43:21 UTC
Seems to be other commands customscript can use (like clang-format), maybe it'd make sense as yet more optfeatures.
Comment 2 Ionen Wolkens gentoo-dev 2021-01-26 14:05:00 UTC
(In reply to Ionen Wolkens from comment #1)
> (like clang-format)
Well, that one was a bad example given it already depend on clang for other reasons.
Comment 3 Andreas Sturmlechner gentoo-dev 2021-02-02 18:08:09 UTC
It was even called the 'indentplugin' once upon a time:

https://invent.kde.org/kdevelop/kdevelop/-/commit/d0c8234bc693c7b2054d9e95014b01f57ec0fd46

Curiously, no other distribution is listing this as a dependency, and even though the description makes it seem as if this is only used to be able to run external scripts (for which the user is very much responsible on their own) there are still these messages related to indent if it is not present.

So optfeature is all that I would do here, and maybe mention uncrustify as well since it is mentioned in the plugin.
Comment 4 Larry the Git Cow gentoo-dev 2021-02-02 19:41:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=77bbb3d7088bb028ba983871ae8397a417fe14da

commit 77bbb3d7088bb028ba983871ae8397a417fe14da
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-02-02 19:36:57 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-02-02 19:37:04 +0000

    dev-util/kdevelop: Add dev-util/indent, dev-util/uncrustify optfeature
    
    Reported-by: Vasiliy Yeremeyev <vayerx@gmail.com>
    Bug: https://bugs.gentoo.org/767286
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/kdevelop/kdevelop-5.6.9999.ebuild | 10 ++++++----
 dev-util/kdevelop/kdevelop-9999.ebuild     | 10 ++++++----
 2 files changed, 12 insertions(+), 8 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-02-02 19:41:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=314e41561a262c854f842ea79fca0ed6afea3063

commit 314e41561a262c854f842ea79fca0ed6afea3063
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-02-02 15:52:52 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-02-02 19:40:20 +0000

    dev-util/kdevelop: 5.6.2 version bump
    
    Closes: https://bugs.gentoo.org/767286
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/kdevelop/Manifest              |   1 +
 dev-util/kdevelop/kdevelop-5.6.2.ebuild | 134 ++++++++++++++++++++++++++++++++
 2 files changed, 135 insertions(+)