Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767163 - media-sound/beets: replaygain TypeError: '>' not supported between instances of 'NoneType' and 'NoneType'
Summary: media-sound/beets: replaygain TypeError: '>' not supported between instances ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Guillaume Seren
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-25 16:26 UTC by Guillaume Seren
Modified: 2021-01-26 11:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Seren 2021-01-25 16:26:43 UTC
Hey,
as reported by juippis, there is a issue in the test suite when using the version 1.4.9-r4, here details:

```
self = <test.test_replaygain.ReplayGainGstCliTest testMethod=test_cli_saves_album_gain_to_file>                                                                                     
                                                                                                                                                                                    
    def test_cli_saves_album_gain_to_file(self):                                                                                                                                    
        for item in self.lib.items():                                                                                                                                               
            mediafile = MediaFile(item.path)                                                                                                                                        
            self.assertIsNone(mediafile.rg_album_peak)                                                                                                                              
            self.assertIsNone(mediafile.rg_album_gain)                                                                                                                              
                                                                                                                                                                                    
        self.run_command(u'replaygain', u'-a')
     
        peaks = []
        gains = []
        for item in self.lib.items():
            mediafile = MediaFile(item.path)
            peaks.append(mediafile.rg_album_peak)
            gains.append(mediafile.rg_album_gain)
     
        # Make sure they are all the same
>       self.assertEqual(max(peaks), min(peaks))
E       TypeError: '>' not supported between instances of 'NoneType' and 'NoneType'

test/test_replaygain.py:137: TypeError
```

The replaygain test need the following package to be installed:
- media-plugins/gst-plugins-libav:1.0
- dev-python/pygobject:3
Comment 1 Larry the Git Cow gentoo-dev 2021-01-26 11:37:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0a1278547950cf7583d3ff964b89766480604c6

commit e0a1278547950cf7583d3ff964b89766480604c6
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2021-01-25 17:04:08 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-26 11:26:16 +0000

    media-sound/beets: Clean old version
    
    Closes: https://bugs.gentoo.org/767163
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/19214
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-1.4.9-r4.ebuild | 137 --------------------------------
 1 file changed, 137 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f8451df5bc09bde7875c15938ef751afb592bf1

commit 6f8451df5bc09bde7875c15938ef751afb592bf1
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2021-01-25 17:03:03 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-26 11:26:16 +0000

    media-sound/beets: Fix replaygain deps 9999
    
    Closes: https://bugs.gentoo.org/767163
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-9999.ebuild | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=db9f2e25fade4c860b55b56fff9132d9fbebffca

commit db9f2e25fade4c860b55b56fff9132d9fbebffca
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2021-01-25 16:59:24 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-26 11:26:16 +0000

    media-sound/beets: Fix replaygain deps v1.4.9-r5
    
    Closes: https://bugs.gentoo.org/767163
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-1.4.9-r5.ebuild | 135 ++++++++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)