Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 766917 - sys-fs/lvm2: drop binutils dependency
Summary: sys-fs/lvm2: drop binutils dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-24 19:24 UTC by David Michael
Modified: 2021-01-24 21:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix.patch (0001-sys-fs-lvm2-drop-unused-binutils-dependency.patch,1.71 KB, patch)
2021-01-24 19:26 UTC, David Michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2021-01-24 19:24:28 UTC
Having binutils in DEPEND causes it to be cross-compiled (since GCC 10 where GCC itself no longer DEPENDs on it), and I don't see where lvm2 requires that.  I don't see any other distros declare this dependency.

If it was just to enforce a minimum version, all versions that do not apply have been gone from the tree for many years (before the initial Git commit).

Please drop the dependency and save a lot of wasted build time.
Comment 1 David Michael 2021-01-24 19:26:41 UTC
Created attachment 684492 [details, diff]
fix.patch
Comment 2 Mike Gilbert gentoo-dev 2021-01-24 21:01:52 UTC
The binutils dependency was added in 2010 to ensure that ld supports the --no-export-dynamic option.

https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=02c3cb9fb55b2c6f5c0ca3bf405d88084b919273

I think the dependency should be removed at this point.
Comment 3 Larry the Git Cow gentoo-dev 2021-01-24 21:05:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5572330c4ebd31ad285859c851a3318599f29d6

commit e5572330c4ebd31ad285859c851a3318599f29d6
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2021-01-24 19:26:22 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-01-24 21:04:03 +0000

    sys-fs/lvm2: drop unused binutils dependency
    
    Closes: https://bugs.gentoo.org/766917
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-fs/lvm2/lvm2-2.02.187-r2.ebuild | 3 +--
 sys-fs/lvm2/lvm2-2.03.11.ebuild     | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)