In file included from src/PluggableFactory.cc:5: src/input/Joystick.hh:43:2: error: ‘openmsx::Joystick::~Joystick()’ marked ‘override’, but does not override 43 | ~Joystick() override; | ^ In file included from src/PluggableFactory.cc:6: ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_systemd-20210115-231509 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-7.3.1 [2] x86_64-pc-linux-gnu-8.3.1 [3] x86_64-pc-linux-gnu-10.2.0 * clang version 11.0.1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/11/bin /usr/lib/llvm/11 11.0.1 Available Python interpreters, in order of preference: [1] python3.8 [2] python2.7 [3] python3.9 (fallback) [4] python3.7 (fallback) Available Ruby profiles: [1] ruby26 (with Rubygems) [2] ruby27 (with Rubygems) * Available Rust versions: [1] rust-1.48.0 * The following VMs are available for generation-2: *) AdoptOpenJDK 8.272_p10 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 system-vm The Glorious Glasgow Haskell Compilation System, version 8.8.4 timestamp(s) of HEAD at this tinderbox image: /var/db/repos/gentoo Fri Jan 22 01:32:57 PM UTC 2021 emerge -qpvO games-emulation/openmsx [ebuild N ] games-emulation/openmsx-16.0
Created attachment 684121 [details] emerge-info.txt
Created attachment 684124 [details] emerge-history.txt
Created attachment 684127 [details] environment
Created attachment 684130 [details] etc.portage.tar.bz2
Created attachment 684133 [details] games-emulation:openmsx-16.0:20210122-144407.log
Created attachment 684136 [details] logs.tar.bz2
Created attachment 684139 [details] temp.tar.bz2
This is caused by libsdl2[-joystick]. After asking in IRC upstream added a patch: https://github.com/openMSX/openMSX/commit/eb5ddae8. I'll open a PR to fixup the dependency momentarily.
Many thanks for looking into this. Why don't we just take the patch instead though?
(In reply to James Le Cuirot from comment #9) > Many thanks for looking into this. Why don't we just take the patch instead > though? Looks to me like it would create an automagic dependency on libsdl2[joystick] or libsdl2[joystick], depending on what was present at build time. We could also add a USE=joystick to openmsx and then a libsdl2[joystick?] dependency, if you think that's a better solution.
Oh, good point. I like that solution but it would have to be libsdl2[joystick=], right?
(In reply to James Le Cuirot from comment #11) > Oh, good point. I like that solution but it would have to be > libsdl2[joystick=], right? Whoops, yep! I've updated the PR. Note I made USE=joystick a default to follow suit with libsdl2.
Umm, don't we need the patch too? ;)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d17bdd5ca9abdc95eaf9c132a6706d70c10ae7c commit 1d17bdd5ca9abdc95eaf9c132a6706d70c10ae7c Author: John Helmert III <jchelmert3@posteo.net> AuthorDate: 2021-01-23 02:54:53 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2021-01-24 23:05:49 +0000 games-emulation/openmsx: fix build failure with libsdl2[-joystick] Closes: https://bugs.gentoo.org/766552 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: John Helmert III <jchelmert3@posteo.net> Closes: https://github.com/gentoo/gentoo/pull/19187 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../files/openmsx-16.0-libsdl-joystick-fix.patch | 66 ++++++++++++++++++++++ ...{openmsx-16.0.ebuild => openmsx-16.0-r1.ebuild} | 7 ++- 2 files changed, 71 insertions(+), 2 deletions(-)
