This file: /usr/lib/python3.9/site-packages/SCons/Platform/posix.py Is missing the line: import os Version 4.0.1 had that line. Reproducible: Always Steps to Reproduce: 1. try to build gpsd 2. 3. Actual Results: # scons scons: Reading SConscript files ... NameError: name 'os' is not defined: File "/u1/local/src/GPS/gpsd/gpsd/SConstruct", line 44: EnsureSConsVersion(2, 3, 0) File "/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 652: env = self.factory() File "/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 632: default_env = SCons.Defaults.DefaultEnvironment() File "/usr/lib/python3.9/site-packages/SCons/Defaults.py", line 84: _default_env = SCons.Environment.Environment(*args, **kw) File "/usr/lib/python3.9/site-packages/SCons/Environment.py", line 974: platform(self) File "/usr/lib/python3.9/site-packages/SCons/Platform/__init__.py", line 124: return self.generate(*args, **kw) File "/usr/lib/python3.9/site-packages/SCons/Platform/posix.py", line 86: if os.environ.get('GENTOO_SCONS_ENV_PASSTHROUGH', False): Expected Results: Pass. Building gpsd works fine with scons 4.0.1, in fact all scons back to 2.3.0. If you look in the file "/usr/lib/python3.9/site-packages/SCons/Platform/posix.py" at line 86, you see that os. is clearly required, but no longer included. Prolly an upstream bug.
here is what upstream says: ```` mwichmannToday at 2:39 PM gentoo packaging is the problem, presumably. scons git posix.py doesn't import os because it doesn't use it, and doesn't know about GENTOO_SCONS_ENV_PASSTHROUGH at all. we have cleaned includes in some files, often through tools pointing out unused imports I see I'm responsible for that removal... so I guess whatever gentoo patch adapts posix.py needs to add the import too. it was commit 22c489260 ```
This Gentoo patch is the problem: dev-util/scons/files/scons-4.1.0-env-passthrough.patch ``` + # Force pass-through of environment variables in Gentoo builds + if os.environ.get('GENTOO_SCONS_ENV_PASSTHROUGH', False): + new_env = os.environ.copy() ``` Since posix.py no longer has "import os" that patch refers to os.environ which is not in scope. The easiest way to fix the patch will be to add back "import os" at the top.
Created attachment 683944 [details] gpsd build.log + emerge --info.txt
Please consider how much I hate SCons while I work on the fix.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d43592155db5c85047c85b92a46638bf0684ae3e commit d43592155db5c85047c85b92a46638bf0684ae3e Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2021-01-21 10:06:58 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2021-01-21 10:20:36 +0000 dev-util/scons: Fix missing os import in Gentoo patch Closes: https://bugs.gentoo.org/766330 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-util/scons/files/scons-4.1.0-env-passthrough.patch | 15 ++++++++------- .../scons/{scons-4.1.0.ebuild => scons-4.1.0-r1.ebuild} | 0 2 files changed, 8 insertions(+), 7 deletions(-)
*** Bug 766387 has been marked as a duplicate of this bug. ***
(In reply to Michał Górny from comment #4) > Please consider how much I hate SCons while I work on the fix. I hate it too. But I hate all other build systems more.
