As discussed with Juippis, here are the following changes: * Replace sphinx with distutils_enable_sphinx (need a patch in the eclass). * Replace the various USE related to plugins with optfeature. * Drop the conditionnal delete of patch (test everything). * Add the plugin deps to test deps.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e2dc6a492f8036d01365a6a9ea542e4145ed87c commit 3e2dc6a492f8036d01365a6a9ea542e4145ed87c Author: Guillaume Seren <guillaumeseren@gmail.com> AuthorDate: 2021-01-22 14:44:57 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-01-24 08:09:06 +0000 media-sound/beets: Delete old version Closes: https://bugs.gentoo.org/766132 Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/19127 Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-sound/beets/beets-1.4.9-r3.ebuild | 162 -------------------------------- 1 file changed, 162 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0f27a00a98b0faf2f66f76e1b8f6fe826cee271 commit a0f27a00a98b0faf2f66f76e1b8f6fe826cee271 Author: Guillaume Seren <guillaumeseren@gmail.com> AuthorDate: 2021-01-19 13:56:08 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-01-24 08:09:05 +0000 media-sound/beets: upgrade live-ebuild Closes: https://bugs.gentoo.org/766132 Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-sound/beets/beets-9999.ebuild | 109 ++++++++++++++---------------------- 1 file changed, 42 insertions(+), 67 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09268b5562c191524cf9fa14f43817b3ba2bf706 commit 09268b5562c191524cf9fa14f43817b3ba2bf706 Author: Guillaume Seren <guillaumeseren@gmail.com> AuthorDate: 2021-01-19 13:53:09 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-01-24 08:09:05 +0000 media-sound/beets: cleanup sphinx & optfeature Closes: https://bugs.gentoo.org/766132 Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-sound/beets/beets-1.4.9-r4.ebuild | 137 +++++++++++++++++++++ ...0003-Try-to-work-around-a-Werkzeug-change.patch | 25 ++++ media-sound/beets/metadata.xml | 14 --- 3 files changed, 162 insertions(+), 14 deletions(-)
>Replace the various USE related to plugins with optfeature What's the reason for this?
(In reply to Simon from comment #2) > >Replace the various USE related to plugins with optfeature > > What's the reason for this? https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001 The previous implementation made little sense even without this policy.
(In reply to Joonas Niilola from comment #3) > (In reply to Simon from comment #2) > > >Replace the various USE related to plugins with optfeature > > > > What's the reason for this? > > https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001 > > The previous implementation made little sense even without this policy. This is still one of the most annoying changes I've run into with packages in the gentoo tree so far. I now have to litter my world file with a bunch of packages I don't care about or create a set just for beets plus all its dependencies I want. Is there really no better way to just track on a package itself which runtime options to support/enable? P.S. Given that beets is a Python package the rationale given doesn't apply, since there's nothing to recompile. Given that, wouldn't it make sense to make an exception for all Python packages (or any interpreted language packages I guess) that don't contain native code?
(In reply to Simon from comment #4) > This is still one of the most annoying changes I've run into with packages > in the gentoo tree so far. I now have to litter my world file with a bunch > of packages I don't care about or create a set just for beets plus all its > dependencies I want. > Is there really no better way to just track on a package itself which > runtime options to support/enable? > > P.S. Given that beets is a Python package the rationale given doesn't apply, > since there's nothing to recompile. Given that, wouldn't it make sense to > make an exception for all Python packages (or any interpreted language > packages I guess) that don't contain native code? I agree it's not perfect. You can make your own portage set called "optfeature" and comment which packages are deps of which packages /etc/portage/sets/optfeature: # media-sound/beets: cat1/pkg1 cat1/pkg2 cat3/pkg1 etc
