Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 765604 - app-misc/rpick-0.7.1 fails tests
Summary: app-misc/rpick-0.7.1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Randy Barlow
URL: https://github.com/bowlofeggs/rpick/i...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-16 08:53 UTC by Agostino Sarubbo
Modified: 2021-01-17 10:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,99.12 KB, text/plain)
2021-01-16 08:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-01-16 08:53:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-misc/rpick-0.7.1 fails tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2021-01-16 08:53:06 UTC
Created attachment 683119 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2021-01-16 08:53:07 UTC
Possible context of error(s):

thread 'cli::error_handling::config_not_found' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::lru::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::inventory::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::error_handling::category_not_found' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::lottery::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::gaussian::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::even::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
thread 'cli::weighted::pick' panicked at 'Failed to spawn rpick: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/cli/mod.rs:102:10
error: test failed, to rerun pass '--test tests'
Comment 3 Randy Barlow 2021-01-16 17:33:06 UTC
Thanks for the bug report!

I know why this is happening. rpick has an integration test suite that expects to find the executable to test at $(pwd)/target/debug/rpick. Gentoo's cargo eclass doesn't produce a debug release (of course ☺) by default, so that path doesn't exist (but $(pwd)/target/release/rpick does exist, I think.)

I think I will try to fix this upstream. This crate looks like it might help with the problem:

https://docs.rs/assert_cmd

If that turns out not to do the trick, I've considered adding an environment variable to influence the path the tests uses to find the executable which I think could work as well.

Also, I realized I had FEATURES="test [and other stuff]" commented out on my development system. I apologize for not catching this myself ☹
Comment 4 Larry the Git Cow gentoo-dev 2021-01-17 10:16:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=582e630c44c804b5b02eb31667fb61cfacb2fda1

commit 582e630c44c804b5b02eb31667fb61cfacb2fda1
Author:     Randy Barlow <randy@electronsweatshop.com>
AuthorDate: 2021-01-17 02:21:01 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-17 10:16:46 +0000

    app-misc/rpick: Replace 0.7.1 with 0.7.2
    
    0.7.1 has a testing issue. Since it is not marked
    stable, this commit replaces it with 0.7.2 to address
    that issue.
    
    Closes: https://bugs.gentoo.org/765604
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
    Closes: https://github.com/gentoo/gentoo/pull/19085
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-misc/rpick/Manifest                                   | 12 ++++++++++--
 app-misc/rpick/{rpick-0.7.1.ebuild => rpick-0.7.2.ebuild} | 12 ++++++++++--
 2 files changed, 20 insertions(+), 4 deletions(-)