Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 765595 - xfce-base/xfce4-meta should depend on xfce-extra/xfce4-volumed-pulse
Summary: xfce-base/xfce4-meta should depend on xfce-extra/xfce4-volumed-pulse
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-16 05:00 UTC by Anthony W
Modified: 2021-01-17 22:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony W 2021-01-16 05:00:16 UTC
I would suggest that xfce-base/xfce4-meta should depend on xfce-extra/xfce4-volumed-pulse, or should be mentioned in the xfce page on the gentoo wiki, as I installed xfce-base/xfce4-meta and was left to search and ask around to find out why the volume control buttons did not function
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-16 08:47:40 UTC
Do you have xfce-extra/xfce4-pulseaudio-plugin installed?  Could you test whether it doesn't do the same thing, possibly with USE=keybinder?  My keyboard is oldschool ;-).
Comment 2 Anthony W 2021-01-16 08:54:03 UTC
(In reply to Michał Górny from comment #1)
> Do you have xfce-extra/xfce4-pulseaudio-plugin installed?  Could you test
> whether it doesn't do the same thing, possibly with USE=keybinder?  My
> keyboard is oldschool ;-).

I do have xfce-extra/xfce4-pulseaudio-plugin installed, it did not work to handle the volume control keys. They only started working after installing xfce-extra/xfce4-volumed-pulse
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-16 08:56:15 UTC
Ok, I'll add both.
Comment 4 Anthony W 2021-01-16 09:13:04 UTC
I could attempt to make sure it compiles with that keybinder flag if needed. I know it was already installed and not handling the vol keys, but I'm unaware of what flags were used when it was installed.
Comment 5 Larry the Git Cow gentoo-dev 2021-01-16 10:11:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a516f858377d56b67eac8d0629a56065288fd533

commit a516f858377d56b67eac8d0629a56065288fd533
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-01-16 08:56:28 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-01-16 09:52:57 +0000

    xfce-base/xfce4-meta: Add pulseaudio-specific deps
    
    Closes: https://bugs.gentoo.org/765595
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 xfce-base/xfce4-meta/xfce4-meta-4.16-r1.ebuild | 40 ++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-17 20:48:34 UTC
(In reply to Anthony W from comment #4)
> I could attempt to make sure it compiles with that keybinder flag if needed.
> I know it was already installed and not handling the vol keys, but I'm
> unaware of what flags were used when it was installed.

Could you try that, after all?  Now I recall why I removed xfce4-volumed-pulse from my system -- if both it and xfce4-pulseaudio-plugin are installed, I get duplicate notifications for volume changes.  Since the latter is more powerful, I think it'd be preferable to use it if it can handle volume keys as well.

Please remember to kill xfce4-volumed-pulse while testing ;-).
Comment 7 Anthony W 2021-01-17 21:05:56 UTC
Just tested it by unmerging xfce4-volumed-pulse and re-merging xfce4-pulseaudio-plugin with the keybinder use added to it, and that worked perfectly. Perhaps adding keybinder to the default use of xfce4-pulseaudio-plugin would be a good idea to avoid this issue for others, or if keybinder is not always used, a note on a wiki page about it?
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-17 22:01:32 UTC
Thanks.  I'll swap the default and update meta.
Comment 9 Anthony W 2021-01-17 22:02:34 UTC
Alright, thank you
Comment 10 Larry the Git Cow gentoo-dev 2021-01-17 22:30:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=281cbb133f012639466b73ef99b08f27e9a454a6

commit 281cbb133f012639466b73ef99b08f27e9a454a6
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-01-17 22:02:53 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-01-17 22:30:18 +0000

    xfce-base/xfce4-meta: Use xfce4-pulseaudio-plugin only
    
    Closes: https://bugs.gentoo.org/765595
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../{xfce4-meta-4.16-r1.ebuild => xfce4-meta-4.16-r2.ebuild}         | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e9cf151d8aac19010f2244112c89d24b361f5f0

commit 3e9cf151d8aac19010f2244112c89d24b361f5f0
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-01-17 22:02:17 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-01-17 22:30:17 +0000

    xfce-extra/xfce4-pulseaudio-plugin: Enable keybinder by default
    
    Bug: https://bugs.gentoo.org/765595
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 ...udio-plugin-0.4.3.ebuild => xfce4-pulseaudio-plugin-0.4.3-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)