Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 765151 - app-editors/scite only installs desktop files if GTK 2 is installed
Summary: app-editors/scite only installs desktop files if GTK 2 is installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ervin Peters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-12 19:49 UTC by Chris Mayo
Modified: 2022-07-23 12:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2021-01-12 19:49:16 UTC
.desktop files and icons are not installed when GTK 2 is not found. Tested using scite-4.2.1 and a custom ebuild for 4.4.6.

Fixed for me by adding GTK3=1 in src_install():

src_install() {
	GTK3=1 default


 >>> Install app-editors/scite-4.2.1 into /var/tmp/portage/app-editors/scite-4.2.1/image
make -j3 DESTDIR=/var/tmp/portage/app-editors/scite-4.2.1/image install 
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
install -m 755 -d /var/tmp/portage/app-editors/scite-4.2.1/image/usr/bin /var/tmp/portage/app-editors/scite-4.2.1/image/usr/share/scite
install -m 755 ./../bin/SciTE /var/tmp/portage/app-editors/scite-4.2.1/image/usr/bin
for files in ./../src/*.properties ./../doc/*.html ./../doc/SciTEIco.png ./../doc/PrintHi.png ./../doc/SciTEIndicators.png; \
do \
	install -m 644 $files /var/tmp/portage/app-editors/scite-4.2.1/image/usr/share/scite; \
done
 >>> Completed installing app-editors/scite-4.2.1 into /var/tmp/portage/app-editors/scite-4.2.1/image
Comment 1 Ionen Wolkens gentoo-dev 2021-01-12 20:50:08 UTC
I can reproduce with 4.4.4-r10 as well.

On a side-note, slotted lua ebuild is missing pkg_setup() with
   use lua && lua-single_pkg_setup
Comment 2 Ervin Peters 2021-12-11 09:13:18 UTC
(In reply to Ionen Wolkens from comment #1)
> I can reproduce with 4.4.4-r10 as well.

Did someone test/reproduce this with the 5.x.x Version?

4.4.4-r10 does no longer build because of an error in ScintillaGTKAccessible.cxx
Comment 3 Chris Mayo 2021-12-12 19:25:35 UTC
Still needed in 5.1.6. My guess - it will still be needed until GTK 2 support is dropped.
Comment 4 Ervin Peters 2022-07-11 15:52:50 UTC
(In reply to Chris Mayo from comment #3)
> Still needed in 5.1.6. My guess - it will still be needed until GTK 2
> support is dropped.

gtk2 is default in src build, after some diskussions about gtk2/3 useflags a while ago we decided to switch to gtk3 as default. But unfortunatelly I missed that the default install process jumps to the source install which therefore needs this parameter set.

I added in in the current PR for the newest scite-5.2.4.ebuild.

ervin
Comment 5 Larry the Git Cow gentoo-dev 2022-07-23 12:50:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68b7958f5d02e5eb5213796be5790b6603017b9b

commit 68b7958f5d02e5eb5213796be5790b6603017b9b
Author:     Ervin Peters <coder@ervnet.de>
AuthorDate: 2022-07-11 15:51:57 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-07-23 12:50:17 +0000

    app-editors/scite: Add Fix from bug #765151
    
    fixes desktop files not installed when gtk2 not found.
    
    Signed-off-by: Ervin Peters <coder@ervnet.de>
    Closes: https://bugs.gentoo.org/765151
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Closes: https://github.com/gentoo/gentoo/pull/26321
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/scite/scite-5.2.4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)