Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764998 - dev-vcs/git-2.30.0[mediawiki-experimental]: cloning from mediawiki fails
Summary: dev-vcs/git-2.30.0[mediawiki-experimental]: cloning from mediawiki fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-11 20:08 UTC by Ulrich Müller
Modified: 2023-03-07 15:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2021-01-11 20:08:33 UTC
With the "mediawiki-experimental" patches enabled, cloning from mediawiki fails:

$ git clone -c remote.origin.namespaces='GLEP' mediawiki::https://wiki.gentoo.org/wiki
Cloning into 'wiki'...
"my" variable @tracked_namespaces masks earlier declaration in same scope at /usr/libexec/git-core/git-remote-mediawiki line 75.
Subroutine get_mw_tracked_namespaces redefined at /usr/libexec/git-core/git-remote-mediawiki line 302.
Undefined subroutine &main::run_git called at /usr/libexec/git-core/git-remote-mediawiki line 75.
$ git clone mediawiki::https://wiki.gentoo.org
Cloning into 'wiki.gentoo.org'...
"my" variable @tracked_namespaces masks earlier declaration in same scope at /usr/libexec/git-core/git-remote-mediawiki line 75.
Subroutine get_mw_tracked_namespaces redefined at /usr/libexec/git-core/git-remote-mediawiki line 302.
Undefined subroutine &main::run_git called at /usr/libexec/git-core/git-remote-mediawiki line 75.
$ 

It appears to work fine with USE="-mediawiki-experimental".
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2021-01-11 22:21:43 UTC
Both flags need to go away. This was a failed experiment, and the patches will never go upstream.
Comment 2 Ulrich Müller gentoo-dev 2021-01-12 08:48:35 UTC
(In reply to Andreas K. Hüttel from comment #1)
> Both flags need to go away. This was a failed experiment, and the patches
> will never go upstream.

USE="mediawiki" enables code that is in upstream's contrib directory:
https://git.kernel.org/pub/scm/git/git.git/tree/contrib/mw-to-git

So I'd rather keep this one, because the functionality is sometimes useful.
Comment 3 Florian Schmaus gentoo-dev 2023-03-07 15:43:33 UTC
I just run into this and found, like others, that disabling the mediawiki-experimental USE flag allows me to "git clone mediawiki::https://wiki.gentoo.org wiki.gentoo.org". So I suggest to keep the mediawiki USE flag but drop the mediawiki-experimental flag.
Comment 4 Larry the Git Cow gentoo-dev 2023-03-07 15:49:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0f438ccc5002f2c4cf1e2a4d7c9a9b26fcf1bb7a

commit 0f438ccc5002f2c4cf1e2a4d7c9a9b26fcf1bb7a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-07 15:49:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-07 15:49:10 +0000

    dev-vcs/git: drop broken USE=mediawiki-experimental
    
    Closes: https://bugs.gentoo.org/764998
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/git/git-2.39.1.ebuild     | 15 +--------------
 dev-vcs/git/git-2.39.2.ebuild     | 15 +--------------
 dev-vcs/git/git-2.40.0_rc0.ebuild | 15 +--------------
 dev-vcs/git/git-9999-r1.ebuild    | 15 +--------------
 dev-vcs/git/git-9999-r2.ebuild    | 15 +--------------
 dev-vcs/git/git-9999-r3.ebuild    | 15 +--------------
 dev-vcs/git/git-9999.ebuild       | 15 +--------------
 dev-vcs/git/metadata.xml          |  1 -
 8 files changed, 7 insertions(+), 99 deletions(-)