764530 – app-emulation/vice-3.5 should depend on media-libs/sdl2-image-2.0.5 while USE=+sdl

Bug 764530 - app-emulation/vice-3.5 should depend on media-libs/sdl2-image-2.0.5 while USE=+sdl

Summary: app-emulation/vice-3.5 should depend on media-libs/sdl2-image-2.0.5 while USE...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2021-01-09 02:46 UTC by Jan Psota
Modified:	2021-01-09 09:45 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jan Psota 2021-01-09 02:46:59 UTC

New vice does not compile without media-libs/sdl2-image (I have 2.0.5) when sdl flag is set.

Comment 1 Sam James archtester

2021-01-09 03:00:32 UTC

A log would be nice just to make it easier to fix.

Comment 2 Sam James archtester

2021-01-09 03:07:41 UTC

Woo:

      dnl Require SDL2_image
      PKG_CHECK_MODULES(SDL2_IMAGE,
                       	[SDL2_image >= 2.0.0],
                       	[have_sdl2_image=yes],
                       	[have_sdl2_image=no; AC_MSG_RESULT([no])])
      if test x"$have_sdl2_image" = "xyes"; then
       	LIBS="$LIBS -lSDL2_image"
      else
       	AC_MSG_ERROR([SDL2_image-dev is required.])
      fi

Comment 3 Larry the Git Cow gentoo-dev

2021-01-09 03:09:55 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=962669a6ce8895201cd8081acfe995b4c7d219d3

commit 962669a6ce8895201cd8081acfe995b4c7d219d3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-01-09 03:09:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-09 03:09:40 +0000

    app-emulation/vice: add sdl2-image dep
    
    Closes: https://bugs.gentoo.org/764530
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 app-emulation/vice/vice-3.5.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comment 4 Sam James archtester

2021-01-09 03:10:04 UTC

Thanks!

Comment 5 Jan Psota 2021-01-09 09:45:53 UTC

You are welcome :-)