Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764482 - net-wireless/iwd-1.11 doesn't need CONFIG_CRYPTO_ARC4
Summary: net-wireless/iwd-1.11 doesn't need CONFIG_CRYPTO_ARC4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal minor
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-08 15:10 UTC by AlexDi
Modified: 2021-01-08 15:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description AlexDi 2021-01-08 15:10:58 UTC
According to this [commit](https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=1db8a85a60c64523) iwd no longer needs ARC4 support in the kernel. It also looks like the tags for 1.9 and 1.10 also include this commit.

In recent kernels CONFIG_CRYPTO_ARC4 is marked as obsoleted with this [commit](https://patchwork.kernel.org/project/linux-nfs/patch/20200831151649.21969-8-ardb@kernel.org/#23607537). The latter commit also states that iwd doesn't need it anymore.

Reproducible: Always

Steps to Reproduce:
1. Build a 5.10 kernel with CRYPTO_USER_API_ENABLE_OBSOLETE disabled.
2. The above will automatically disable CONFIG_CRYPTO_ARC4
3. Try to build iwd-1.11, it will fail with error that CONFIG_CRYPTO_ARC4 is not enabled.
Actual Results:  
Iwd build fails.

Expected Results:  
According to the referenced commits this configuration option should not be needed and the iwd build should succeed.

I can provide a patch if requested.
Comment 1 AlexDi 2021-01-08 15:11:42 UTC
emerge --info
Portage 3.0.12 (python 3.8.7-final-0, default/linux/amd64/17.1/hardened, gcc-10.2.0, glibc-2.32-r7, 5.10.5-gentoo-x86_64 x86_64)
=================================================================
System uname: Linux-5.10.5-gentoo-x86_64-x86_64-Intel-R-_Core-TM-_i7-4702MQ_CPU_@_2.20GHz-with-glibc2.2.5
KiB Mem:    16309732 total,   9216988 free
KiB Swap:    9767932 total,   9767932 free
Timestamp of repository gentoo: Fri, 08 Jan 2021 00:45:01 +0000
sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
app-shells/bash:          5.1_p4::gentoo
dev-lang/perl:            5.32.0-r1::gentoo
dev-lang/python:          3.7.9-r1::gentoo, 3.8.7::gentoo, 3.9.1::gentoo
dev-util/cmake:           3.19.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

my_repo
    location: /var/db/repos/my_repo
    masters: gentoo
    priority: 10

gentoo
    location: /usr/portage
    sync-type: webrsync
    sync-uri: https://mirror.eu.oneandone.net/linux/distributions/gentoo/gentoo/
    priority: 100
    sync-webrsync-verify-signature: true

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native -ggdb"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="--jobs 8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
USE="X acl acpi alsa amd64 bzip2 crypt dbus dri dvd dvdr elogind encode fam flac glamor hardened iconv icu ipv6 jpeg kde libglvnd libtirpc mmx mp3 mp4 multilib ncurses networkmanager nls nptl ogg opengl openmp pam pcre phonon pie pm-utils png policykit pulseaudio qt5 readline seccomp split-usr sse sse2 sse3 sse4_1 ssl ssp ssse3 svg tiff truetype udev unicode upower vaapi vim-syntax vorbis wayland x264 xattr xml xtpax zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev synaptics" KERNEL="linux" L10N="en-US en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="BPF" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8 python3_7" RUBY_TARGETS="ruby26 ruby27 ruby30" USERLAND="GNU" VIDEO_CARDS="intel i965 nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Ben Kohler gentoo-dev 2021-01-08 15:19:29 UTC
Thanks for reporting the unneeded ARC4 option, I will remove it.

But, this shouldn't make your build fail.  All of the config checks are non-fatal here (CONFIG_CHECK="~CRYPTO_ARC4" instead of CONFIG_CHECK="CRYPTO_ARC4").
Comment 3 Larry the Git Cow gentoo-dev 2021-01-08 15:24:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a4777958c9e3d1bb0609106f3ebb037cc630028

commit 4a4777958c9e3d1bb0609106f3ebb037cc630028
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2021-01-08 15:23:50 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2021-01-08 15:24:38 +0000

    net-wireless/iwd: no longer check for CONFIG_ARC4
    
    Per
    https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=1db8a85a60c64523
    
    Closes: https://bugs.gentoo.org/764482
    
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-wireless/iwd/iwd-1.10.ebuild | 1 -
 net-wireless/iwd/iwd-1.11.ebuild | 1 -
 2 files changed, 2 deletions(-)
Comment 4 AlexDi 2021-01-08 15:53:27 UTC
(In reply to Ben Kohler from comment #2)
> But, this shouldn't make your build fail.  All of the config checks are
> non-fatal here (CONFIG_CHECK="~CRYPTO_ARC4" instead of
> CONFIG_CHECK="CRYPTO_ARC4").

You are correct - it actually failed due to ell-0.35 dependency, which I saw that it is already fixed. I misread the output from emerge.

Thanks a lot for the prompt reaction!