Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764374 - lxde-base/lxdm: needs gettext in BDEPEND
Summary: lxde-base/lxdm: needs gettext in BDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Brian Evans (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-01-07 19:50 UTC by David Michael
Modified: 2021-02-07 15:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2021-01-07 19:50:10 UTC
The LXDM ebuild has gettext in DEPEND, which causes it to be cross-compiled.  I don't see where it would need the cross-compiled package, but it does need to call at least gmsgfmt natively, so it should moved to BDEPEND.

--- lxde-base/lxdm/lxdm-0.5.3-r2.ebuild
+++ lxde-base/lxdm/lxdm-0.5.3-r2.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
@@ -20,15 +20,17 @@
 	x11-libs/libxcb
 	gtk3? ( x11-libs/gtk+:3 )
 	!gtk3? ( x11-libs/gtk+:2 )
-	nls? ( sys-devel/gettext )
 	pam? ( sys-libs/pam )"
 # We only use the pam modules and not actually link to the code
 RDEPEND="${DEPEND}
 	elogind? ( sys-auth/elogind[pam] )
 	systemd? ( sys-apps/systemd[pam] )
 "
-BDEPEND=">=dev-util/intltool-0.40
-	virtual/pkgconfig"
+BDEPEND="
+	>=dev-util/intltool-0.40
+	virtual/pkgconfig
+	nls? ( sys-devel/gettext )
+"
 DOCS=( AUTHORS README TODO )
 
 REQUIRED_USE="?? ( elogind systemd ) elogind? ( pam ) systemd? ( pam )"
Comment 1 Larry the Git Cow gentoo-dev 2021-02-07 15:09:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=133185247ecebbea59813a5ca4711137ee522a98

commit 133185247ecebbea59813a5ca4711137ee522a98
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2021-02-07 15:07:28 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2021-02-07 15:09:38 +0000

    lxde-base/lxdm: Move gettext from DEPEND to BDEPEND
    
    Only affects cross-compilation
    
    Closes: https://bugs.gentoo.org/764374
    Signed-off-by: Brian Evans <grknight@gentoo.org>

 lxde-base/lxdm/lxdm-0.5.3-r2.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)