Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764224 - app-misc/task-2.5.3: version bump
Summary: app-misc/task-2.5.3: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Denoncin
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-07 02:48 UTC by Sam James
Modified: 2021-02-28 09:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,101.96 KB, text/plain)
2021-01-09 20:55 UTC, David Denoncin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-01-07 02:48:01 UTC
Thanks.
Comment 1 David Denoncin 2021-01-09 20:55:06 UTC
Created attachment 682171 [details]
build.log
Comment 2 David Denoncin 2021-01-09 20:56:58 UTC
I'm having trouble with this update (several hundred commits since last version and limited time to investigate). I've attached the current build.log, if anyone can point me into the right direction ?
Comment 3 Michael Meier 2021-02-20 14:03:57 UTC
Hi David,

the problem is that the internal libraries get linked as shared libraries.

See the add_library commands in [1], which are missing the STATIC/SHARED keyword. When that keyword is missing, CMake looks at the "BUILD_SHARED_LIBS" option, which for some reason is ON by default in Gentoo builds. Running the same build outside portage works and builds the libraries as STATIC libs.

When shared libraries are linked, CMake removes duplicates from the linker invocation, leading to the linker error due to the order-sensitivity of linking.

Simplest fix: Just add "-DBUILD_SHARED_LIBS=off" to the Ebuild's src_configure mycmakeargs. The build ran through cleanly for me then (after also removing the two patches).
Comment 4 Michael Meier 2021-02-20 14:06:20 UTC
Hmpf, forgot to add the link and can't edit my comment:

[1] https://github.com/GothenburgBitFactory/taskwarrior/blob/v2.5.3/src/CMakeLists.txt

This problem with missing STATIC/SHARED keyword seems to have already been fixed on upstream's master, as the STATIC keyword is now present in the add_library calls:

https://github.com/GothenburgBitFactory/taskwarrior/commit/9548bfdabaf6cba19ee061d2a7a2d86f15d21af3
Comment 5 David Denoncin 2021-02-21 09:17:44 UTC
Excellent, thanks a lot! I added the fix to the ebuild and will get rid of that when the next version is out.
Comment 6 Larry the Git Cow gentoo-dev 2021-02-28 09:03:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54b5f8db3dac5a8e8e5ff81b1d88f4292ee4221f

commit 54b5f8db3dac5a8e8e5ff81b1d88f4292ee4221f
Author:     David Denoncin <ddenoncin@gmail.com>
AuthorDate: 2021-02-21 09:11:52 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-02-28 09:03:08 +0000

    app-misc/task: vbump 2.5.3
    
    Closes: https://bugs.gentoo.org/764224
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: David Denoncin <ddenoncin@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-misc/task/Manifest          |  1 +
 app-misc/task/task-2.5.3.ebuild | 57 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)