Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764218 - app-emulation/vice-3.4_p38553 - .../src/opencbm.h:161:46: error: unknown type name '__u_char' (on musl)
Summary: app-emulation/vice-3.4_p38553 - .../src/opencbm.h:161:46: error: unknown type...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on: 761529
Blocks: missing-musl-includes
  Show dependency tree
 
Reported: 2021-01-07 00:30 UTC by ernsteiswuerfel
Modified: 2021-01-07 16:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (vice-3.4_p38553:20210106-213417.log,388.97 KB, text/plain)
2021-01-07 00:30 UTC, ernsteiswuerfel
Details
emerge --info (file_764218.txt,6.73 KB, text/plain)
2021-01-07 00:31 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2021-01-07 00:30:49 UTC
Created attachment 681595 [details]
build.log

[...]
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/serial -I../../src  -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/systemheaderoverride -DNDEBUG -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/arch/gtk3 -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/arch -I../../src -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/drive -I/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/lib/p64  -Wall -Wformat -Wformat-signedness -Wshadow -Wpointer-arith -Wstrict-prototypes -Wuninitialized -Wunreachable-code -Wno-unused-parameter -Werror=implicit-function-declaration -Wfatal-errors -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/libffi/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -pthread  -pthread -Os -march=x86-64 -msse3 -mtune=athlon64-sse3 -pipe -c -o realdevice.o /var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/serial/realdevice.c
In file included from /var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/opencbmlib.h:31,
                 from /var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/serial/realdevice.c:34:
/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice/src/opencbm.h:161:46: error: unknown type name '__u_char'; did you mean 'u_char'?
  161 | EXTERN int CBMAPIDECL cbm_listen(CBM_FILE f, __u_char dev, __u_char secadr);
      |                                              ^~~~~~~~
      |                                              u_char
compilation terminated due to -Wfatal-errors.
make[3]: *** [Makefile:522: realdevice.o] Error 1
make[3]: Leaving directory '/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice-gtk/src/serial'
make[2]: *** [Makefile:2034: all-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice-gtk/src'
make[1]: *** [Makefile:1790: all] Error 2
make[1]: Leaving directory '/var/tmp/portage/app-emulation/vice-3.4_p38553/work/vice-emu-code-r38553-trunk-vice-gtk/src'
make: *** [Makefile:523: all-recursive] Error 1
 * ERROR: app-emulation/vice-3.4_p38553::gentoo failed (compile phase):
 *   emake failed
Comment 1 ernsteiswuerfel archtester 2021-01-07 00:31:15 UTC
Created attachment 681598 [details]
emerge --info
Comment 2 ernsteiswuerfel archtester 2021-01-07 00:38:59 UTC
New upstream vice 3.5 is not affected and builds fine from its' source tarball on musl.

Looks like they got rid of a lot of the #ifdef stuff they had in former versions' headers. At least that's the case as far as opencbm.h is concerned.
Comment 3 groepaz 2021-01-07 11:51:58 UTC
indeed, we have been trying to remove a lot of the historic ifdef hell :)
Comment 4 ernsteiswuerfel archtester 2021-01-07 15:21:04 UTC
(In reply to groepaz from comment #3)
> indeed, we have been trying to remove a lot of the historic ifdef hell :)
Guess you are involved in the project then? Nice, thanks! More standard C is good for musl and good for alternative OSes like MorphOS. ;)
Comment 5 Larry the Git Cow gentoo-dev 2021-01-07 16:28:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=901063aa932d2d1cb1ed9215b30d782b093f4478

commit 901063aa932d2d1cb1ed9215b30d782b093f4478
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2021-01-07 16:28:06 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2021-01-07 16:28:06 +0000

    app-emulation/vice: Version bump to 3.5
    
    This fixes building against musl.
    
    Closes: https://bugs.gentoo.org/761529
    Closes: https://bugs.gentoo.org/764218
    Package-Manager: Portage-3.0.12, Repoman-3.0.1
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 app-emulation/vice/Manifest        |   1 +
 app-emulation/vice/vice-3.5.ebuild | 166 +++++++++++++++++++++++++++++++++++++
 2 files changed, 167 insertions(+)