Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 763123 - net-misc/wget-1.21: fails to compile due to missing errno
Summary: net-misc/wget-1.21: fails to compile due to missing errno
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://lists.gnu.org/archive/html/bu...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-02 14:24 UTC by Fabian Groffen
Modified: 2021-01-14 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2021-01-02 14:24:42 UTC
At least on Darwin:

powerpc-apple-darwin9-gcc -DHAVE_CONFIG_H -I. -I../src  -DDEFAULT_TEXT_DOMAIN=\"wget-gnulib\" -DGNUSTEP_BASE_VERSION -I/Volumes/Scratch/Gentoo/bootstrap32-20201231/usr/include   -DHAVE_LIBSSL  -DNDEBUG  -c -o utime.o utime.c
utime.c: In function 'rpl_utime':
utime.c:279:38: error: 'errno' undeclared (first use in this function)
  279 |       if (stat (name, &buf) == -1 && errno != EOVERFLOW)
      |                                      ^~~~~
utime.c:266:1: note: 'errno' is defined in header '<errno.h>'; did you forget to '#include <errno.h>'?
  265 | # include "filename.h"
  +++ |+#include <errno.h>
  266 |
utime.c:279:38: note: each undeclared identifier is reported only once for each function it appears in
  279 |       if (stat (name, &buf) == -1 && errno != EOVERFLOW)
      |                                      ^~~~~
utime.c:279:47: error: 'EOVERFLOW' undeclared (first use in this function)
  279 |       if (stat (name, &buf) == -1 && errno != EOVERFLOW)
      |                                               ^~~~~~~~~
make[3]: *** [Makefile:2588: utime.o] Error 1

As GCC (10.1.0) suggests, errno.h needs to be included.

Ok, if I add a patch doing so?
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-02 15:05:33 UTC
(In reply to Fabian Groffen from comment #0)
> 
> Ok, if I add a patch doing so?

Yeah, go ahead.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-02 15:31:38 UTC
This has already been reported upstream (see URL).
Comment 3 Larry the Git Cow gentoo-dev 2021-01-02 18:52:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9bf03680ff02e09c1cef7dd05f9634d459a3957f

commit 9bf03680ff02e09c1cef7dd05f9634d459a3957f
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2021-01-02 18:48:23 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-01-02 18:48:23 +0000

    net-misc/wget-1.21-r1: revbump, gnulib fix for Darwin, Solaris
    
    Closes: https://bugs.gentoo.org/763123
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 .../wget/files/wget-1.21-gnulib-utime-errno.patch  |  30 +++++
 net-misc/wget/wget-1.21-r1.ebuild                  | 129 +++++++++++++++++++++
 2 files changed, 159 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2021-01-14 18:58:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea42567e6863407c5635541cbd22de085bdb9810

commit ea42567e6863407c5635541cbd22de085bdb9810
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-01-14 18:56:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-14 18:56:49 +0000

    profiles/prefix/package.mask: drop obsolete wget mask
    
    This version is no longer in tree.
    
    Bug: https://bugs.gentoo.org/763123
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/prefix/package.mask | 5 -----
 1 file changed, 5 deletions(-)