Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762982 - sci-physics/bullet-3.07: bring back extras use flag
Summary: sci-physics/bullet-3.07: bring back extras use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Ross Charles C.
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-01 20:55 UTC by eluancm
Modified: 2021-06-02 12:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eluancm 2021-01-01 20:55:10 UTC
Is there any reason why the "extras" use flag was dropped from the bullet-3.xx ebuilds? They are present in the bullet-2.xx ebuilds and I depend on it. If the new version is stabilized I will have to use a local overlay for this.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-01-01 21:20:38 UTC
It was dropped in the linked PR, but why?
Comment 2 Ionen Wolkens gentoo-dev 2021-01-01 21:30:03 UTC
(In reply to Andreas Sturmlechner from comment #1)
> It was dropped in the linked PR, but why?
Not sure if because of that but seems upstream changed things around and leads to build failure without right flags.

Notably need to enable demos, this built for me:
    -DBUILD_OPENGL3_DEMOS=ON
    -DBUILD_BULLET2_DEMOS=ON
    -DBUILD_EXTRAS=ON
    -DINSTALL_EXTRA_LIBS=ON
Comment 3 Ross Charles C. 2021-01-03 17:23:41 UTC
(In reply to Ionen Wolkens from comment #2)
> (In reply to Andreas Sturmlechner from comment #1)
> > It was dropped in the linked PR, but why?
> Not sure if because of that but seems upstream changed things around and
> leads to build failure without right flags.
> 
> Notably need to enable demos, this built for me:
>     -DBUILD_OPENGL3_DEMOS=ON
>     -DBUILD_BULLET2_DEMOS=ON
>     -DBUILD_EXTRAS=ON
>     -DINSTALL_EXTRA_LIBS=ON

That's the case. We can't build extra libs without also building the examples
Comment 4 Samuel Bauer 2021-05-04 00:22:02 UTC
here I compiled without demos just:
    -DBUILD_EXTRAS=ON
    -DINSTALL_EXTRA_LIBS=ON

Had to add this when preparing sources:

sed -i -e 's/ BulletExampleBrowserLib//' Extras/BulletRoboticsGUI/CMakeLists.txt


Extra flag would really be welcome back.
Comment 5 Larry the Git Cow gentoo-dev 2021-06-02 12:59:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=291af15b301069748e61770752ecc91b49be89cb

commit 291af15b301069748e61770752ecc91b49be89cb
Author:     Ross Charles Campbell <rossbridger.cc@gmail.com>
AuthorDate: 2021-05-10 23:36:26 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-06-02 12:59:04 +0000

    sci-physics/bullet: bump to 3.17
    
    This version reintroduced "extras" USE flag
    
    Closes: https://bugs.gentoo.org/765556
    Closes: https://bugs.gentoo.org/762982
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Closes: https://github.com/gentoo/gentoo/pull/20764
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sci-physics/bullet/Manifest           |  1 +
 sci-physics/bullet/bullet-3.17.ebuild | 87 +++++++++++++++++++++++++++++++++++
 sci-physics/bullet/metadata.xml       |  5 +-
 3 files changed, 91 insertions(+), 2 deletions(-)