Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762940 - dev-java/jna-4.2.2-r1[-awt] may not need x11-libs/libXt
Summary: dev-java/jna-4.2.2-r1[-awt] may not need x11-libs/libXt
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-01 16:21 UTC by Dennis Nezic
Modified: 2022-06-17 08:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nezic 2021-01-01 16:21:42 UTC
When trying to upgrade a package that depended on dev-java/jna:4, I was shocked to find that it was pulling in a bunch of x11 stuff, on my headless server. It turns out, it didn't in fact need x11-libs/libXt. (It specifies -Dheadless=true elsewhere in the ebuild, which should have suggested this.)

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-01-01 16:55:55 UTC
headless=true is only for tests as far as I'm aware and I tried to force build it without libXt (which provides Intrinsic.h) and then:

fatal error: X11/Intrinsic.h: No such file or directory
Comment 2 Dennis Nezic 2021-01-01 17:02:59 UTC
Very interesting. I wonder why it worked for me, or why it's required for you.
Comment 3 Ionen Wolkens gentoo-dev 2021-01-01 17:10:01 UTC
(In reply to Dennis Nezic from comment #2)
> Very interesting. I wonder why it worked for me, or why it's required for
> you.
I see now, it's because I had the default USE=awt (works without, but haven't thoroughly tested).

I guess it may(?) be possible to make it conditional, java team will know better.
Comment 4 Larry the Git Cow gentoo-dev 2022-01-09 09:07:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a0f8afba88fd7f3a7813c280e9d87074f5f459a

commit 1a0f8afba88fd7f3a7813c280e9d87074f5f459a
Author:     Yuan Liao <liaoyuan@gmail.com>
AuthorDate: 2022-01-08 22:30:57 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-01-09 09:07:17 +0000

    dev-java/jna: DEPEND on x11-libs/libXt for 5.10.0
    
    The 'awt' USE flag has not been added to 5.10.0, which is effectively
    like this USE flag is enabled by default (dev-java/jna[awt(+)]).  Bug
    830812 shows that x11-libs/libXt is still required for 5.10.0.  Another
    long-existing bug 762940 suggests that if the ebuild had the 'awt' USE
    flag and it was disabled then libXt might be redundant, but that is not
    applicable to this case.
    
    As of the commit time, based on experiments in containers created from
    the gentoo/stage3 Docker image, declaration of x11-libs/libXt as a
    dependency would only cause 3 additional packages to be installed in a
    new copy of stage3, none of which would take a very long time to merge,
    so the benefit of making the dependency optional via the 'awt' USE flag
    might not be very significant.
    
    Bug: https://bugs.gentoo.org/762940
    Closes: https://bugs.gentoo.org/830812
    Signed-off-by: Yuan Liao <liaoyuan@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/23708
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 dev-java/jna/jna-5.10.0.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-06-17 08:15:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ffc74f6e03748a09db665fcd2d65af67d7db1b88

commit ffc74f6e03748a09db665fcd2d65af67d7db1b88
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2022-06-15 16:57:59 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-06-17 08:15:33 +0000

    dev-java/jna: drop 4.2.2-r3
    
    Closes: https://bugs.gentoo.org/762940
    Closes: https://bugs.gentoo.org/833325
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/25913
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 dev-java/jna/Manifest                    |  1 -
 dev-java/jna/files/4.2.2-build.xml.patch | 23 ---------
 dev-java/jna/jna-4.2.2-r3.ebuild         | 87 --------------------------------
 dev-java/jna/metadata.xml                |  4 --
 4 files changed, 115 deletions(-)