Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762766 - sys-kernel/raspberrypi-sources-5.4.79_p20201201[symlink]: wrong symlink in /usr/src
Summary: sys-kernel/raspberrypi-sources-5.4.79_p20201201[symlink]: wrong symlink in /u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sam James
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-12-31 10:35 UTC by Another Mortal
Modified: 2021-02-14 15:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-sys-kernel-raspberrypi-sources-fix-symlink-with-USE-.patch (0001-sys-kernel-raspberrypi-sources-fix-symlink-with-USE-.patch,1.40 KB, patch)
2020-12-31 12:41 UTC, Ionen Wolkens
Details | Diff
raspberrypi-sources.diff (raspberrypi-sources.diff,2.45 KB, patch)
2021-01-01 12:14 UTC, ShorTie
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Another Mortal 2020-12-31 10:35:40 UTC
Something got messed up with naming/versioning and the ebuild creates a dangling symlink preventing kernel-dependent packages from finding the relevant configuration...

lrwxrwxrwx  1 root root   34 Dec 13  2020 linux -> linux-5.4.79_p20201201-raspberrypi
drwxr-xr-x 25 root root 4096 Dec 15  2020 linux-raspberrypi-kernel_1.20201201-1
Comment 1 Ionen Wolkens gentoo-dev 2020-12-31 12:41:38 UTC
Created attachment 680425 [details, diff]
0001-sys-kernel-raspberrypi-sources-fix-symlink-with-USE-.patch

eselect kernel seems to handle this fine, so it's just USE=symlink and the snapshot

Here's a patch but not convinced it's 100% right, hope it helps anyway.
rt-sources also uses KV_FULL for comparison.
Comment 2 Ionen Wolkens gentoo-dev 2020-12-31 13:08:05 UTC
(In reply to Ionen Wolkens from comment #1)
> not convinced it's 100% right
Probably not worth it until a version bump, but renaming the tarball to linux-... and using kernel-2's native src_unpack() to move the source directory to regular linux-${KV_FULL} may make more sense (might require fiddling with other variables, haven't tried).
Comment 3 ShorTie 2021-01-01 12:14:49 UTC
Created attachment 680500 [details, diff]
raspberrypi-sources.diff

Thankz for the symlink.

But I think it was still not configuring properly.
This patch grows on yours with some configuring.
It uses either `cat /proc/cpuinfo` or a
BOARD variable can be passed by /etc/portage/make.conf,	like BOARD="pi4-64"
I think this should stabilize it too....

A pre patched ebuild can be found here, for quick testing maybe.
wget https://raw.githubusercontent.com/ShorTie8/Gentoo-imager/master/overlay/sys-kernel/raspberrypi-sources/raspberrypi-sources-5.4.79_p20201201.ebuild
Comment 4 Larry the Git Cow gentoo-dev 2021-02-05 18:51:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13879e90b2639feb21725785ec5070b79e5d8757

commit 13879e90b2639feb21725785ec5070b79e5d8757
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-05 18:50:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-05 18:51:45 +0000

    sys-kernel/raspberrypi-sources: rename tarball for 5.10 (for now)
    
    Closes: https://bugs.gentoo.org/762766
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-kernel/raspberrypi-sources/Manifest                          | 2 +-
 .../raspberrypi-sources-5.10.11_p20210201.ebuild                 | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40696e5680e8d00928e9ebca1fea5c4ed2035673

commit 40696e5680e8d00928e9ebca1fea5c4ed2035673
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2020-12-31 12:32:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-05 18:51:39 +0000

    sys-kernel/raspberrypi-sources: fix symlink with USE=symlink
    
    Closes: https://bugs.gentoo.org/762766
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../raspberrypi-sources-5.10.11_p20210201.ebuild                  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)