Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762613 - app-emulation/libguestfs `gettext-stub' not found with dev-ml/ocaml-gettext-0.4.2
Summary: app-emulation/libguestfs `gettext-stub' not found with dev-ml/ocaml-gettext-0...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-30 09:50 UTC by Kamil Dudka
Modified: 2021-01-22 03:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hacky ocaml-gettext-stub ebuild (ocaml-gettext-stub-0.4.2.ebuild,733 bytes, text/plain)
2021-01-11 20:51 UTC, Hank Leininger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Dudka 2020-12-30 09:50:59 UTC
app-emulation/libguestfs-1.38.6-r100 fails to build with the ocaml use flag against dev-ml/ocaml-gettext-0.4.2.

Reproducible: Always

Steps to Reproduce:
1. update dev-ml/ocaml-gettext to 0.4.2
2. (re)build app-emulation/libguestfs-1.38.6-r100 with ocaml use flag enabled
Actual Results:  
The build fails with:

    ocamlfind: Package `gettext-stub' not found

Expected Results:  
Successful build.

Downgrading to dev-ml/ocaml-gettext-0.3.7-r2 fixes the build failure.
Comment 1 Ionen Wolkens gentoo-dev 2020-12-30 11:06:55 UTC
Tentatively assigning to libguestfs because seems missing a
separated dependency.

gettext-stub and gettext-camomile were split off from ocaml-gettext
in the dune migration, I guess need a new ocaml-gettext-stub package.
https://opam.ocaml.org/packages/gettext-stub/
Comment 2 Ionen Wolkens gentoo-dev 2020-12-30 19:52:25 UTC
CC'ing sam given did the ocaml-gettext version bump, and not sure if more packages need gettext-stub and could lead to surprises.
Comment 3 Ionen Wolkens gentoo-dev 2020-12-30 20:39:37 UTC
(In reply to Ionen Wolkens from comment #2)
> and not sure if more packages need gettext-stub and could lead to surprises.
Well, upon closer look only libguestfs needs ocaml-gettext right now, so it makes the package useless without gettext-stub.
Comment 4 Kamil Dudka 2020-12-30 20:43:57 UTC
Thanks for the quick response on this!
Comment 5 Árni Dagur 2021-01-02 16:57:32 UTC
I can reproduce this issue on my system.
Comment 6 Hank Leininger 2021-01-11 20:51:25 UTC
Created attachment 682474 [details]
hacky ocaml-gettext-stub ebuild

Here is an experimental ebuild for ocaml-gettext-stub which installs for me and allows me to rebuild the latest libguestfs. Either emerge this manually first, or make a local overlay copy of libguestfs and change its dev-ml/ocaml-gettext dependency to dev-ml/ocaml-gettext-stub

N.B. I have no idea what I'm doing with dev-ml or the dune build system, this is literally "Oh God it compiled, ship it."
Comment 7 Rafael Kitover 2021-01-15 11:20:36 UTC
Hank, that looks pretty good, not sure about the src_install and RESTRICT. The best way to contribute to Gentoo right now is through Github PRs. You just fork gentoo/gentoo and create one. You can put me down as the proxy maint, but there is no reason you can't join us either. If you need help with any of this come to #gentoo-proxy-maint on freenode.
Comment 8 Hank Leininger 2021-01-17 20:09:33 UTC
(In reply to Rafael Kitover from comment #7)
> Hank, that looks pretty good, not sure about the src_install and RESTRICT.
> The best way to contribute to Gentoo right now is through Github PRs. You
> just fork gentoo/gentoo and create one. You can put me down as the proxy
> maint, but there is no reason you can't join us either. If you need help
> with any of this come to #gentoo-proxy-maint on freenode.

Thank you! Indeed, I p-m a couple of packages. I was reluctant to attempt that here or even issue a PR given that I *really* am not familiar with ocaml and was pretty certain my hacked-up approach was good for nothing but a proof-of-concept.

When submitting PRs and p-m requests I have found I will be required to fix every nit in the original .ebuild I am basing my changes on, before the actual bugfix will be accepted/merged. So I did not want to bite off that much in this particular case.

I see you have taken this up and submitted split-ebuilds, thanks!
Comment 9 Larry the Git Cow gentoo-dev 2021-01-22 03:34:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f8bccf0f8d9c4eb50bef8ec9c7423c8af7935ea

commit 9f8bccf0f8d9c4eb50bef8ec9c7423c8af7935ea
Author:     Rafael Kitover <rkitover@gmail.com>
AuthorDate: 2021-01-19 23:26:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-22 03:33:58 +0000

    app-emulation/libguestfs: Dep ocaml-gettext-stub.
    
    Depend on ocaml-gettext-stub instead of ocaml-gettext or ocaml-gettext
    versions lower than 0.4.2, which is before the -stub package was split
    off.
    
    Closes: https://bugs.gentoo.org/762613
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Rafael Kitover <rkitover@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/19095
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{libguestfs-1.36.13-r1.ebuild => libguestfs-1.36.13-r2.ebuild}   | 5 ++++-
 .../{libguestfs-1.36.15-r1.ebuild => libguestfs-1.36.15-r2.ebuild}   | 5 ++++-
 app-emulation/libguestfs/libguestfs-1.38.6-r1.ebuild                 | 5 ++++-
 .../{libguestfs-1.38.6-r101.ebuild => libguestfs-1.38.6-r102.ebuild} | 5 ++++-
 4 files changed, 16 insertions(+), 4 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e27f3e8b522b77b41f3b4f3c3be794d9d897c1ba

commit e27f3e8b522b77b41f3b4f3c3be794d9d897c1ba
Author:     Rafael Kitover <rkitover@gmail.com>
AuthorDate: 2021-01-17 19:30:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-22 03:33:57 +0000

    dev-ml/ocaml-gettext-camomile: New ebuild.
    
    Part of the ocaml-gettext distribution.
    
    Bug: https://bugs.gentoo.org/762613
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Rafael Kitover <rkitover@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-ml/ocaml-gettext-camomile/Manifest             |  1 +
 dev-ml/ocaml-gettext-camomile/metadata.xml         | 21 ++++++++++++++
 .../ocaml-gettext-camomile-0.4.2.ebuild            | 33 ++++++++++++++++++++++
 3 files changed, 55 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d798bad94cd1f2b11d5f4b36a7b358e55d7a9938

commit d798bad94cd1f2b11d5f4b36a7b358e55d7a9938
Author:     Rafael Kitover <rkitover@gmail.com>
AuthorDate: 2021-01-17 19:24:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-22 03:33:57 +0000

    dev-ml/ocaml-gettext-stub: New ebuild.
    
    Needed for libguestfs.
    
    First version of ebuild provided by:
    Hank Leininger (hlein@korelogic.com).
    
    Bug: https://bugs.gentoo.org/762613
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Rafael Kitover <rkitover@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-ml/ocaml-gettext-stub/Manifest                 |  1 +
 dev-ml/ocaml-gettext-stub/metadata.xml             | 21 ++++++++++++++
 .../ocaml-gettext-stub-0.4.2.ebuild                | 33 ++++++++++++++++++++++
 3 files changed, 55 insertions(+)