https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-gfx/valentina-0.6.1-r1 calls commands that do not exist. Discovered on: amd64 (internal ref: ci)
Created attachment 680260 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Roman, could you please have a look at this? it's the code in common.pri that attempts to fill the DVCS_HESH variable. users might not have hg nor git installed on their system and though this issue is not fatal, it could be avoided by checking whether the command is available. what do you think?
In case hg or git is not installed script just sets a hash value to "unknown". So, I don't see a reason to add something else.
if i get it right, there is no check whether the commands are available or not, they are just called and if they fail, it works as you wrote. nontheless this report is about the error output when those commands are called but not installed. this is from the compilation output: sh: line 1: hg: command not found i can sure patch it out for the versioned releases as there is no hg/git repo anyway, and also patch out hg for the live ebuild as it's git based. i just thought it might be better to add a check into common.pri whether the command is available or not to avoid the error message "command not found".
Do you have an idea of how to add such a check? Because my approach was to call, check a result, react to it. This is why you see this error message that just means you don't have hg/git, nothing more. Not critical and must be just ignored.
not at all. but i can simply patch it out to avoid the error (warning) :-)
Okay. I will add a config option to help people to suppress if they wish not to add a hash value.
thanks! that'd be great :-) could you also switch the order to git -> hg instead of hg -> git?
i mean to first check for git output and then for hg. in that case i could still use the check for the live ebuild.
It will take some time. I am very busy these days.
no worries at all. this is a trivial issue from the point of view of users, it's rather qa issue. it does not affect installing and using valentina at all.
We no longer have calls to HG in develop and 0.6.x branches. New releases will fix this issue. But you can also create a patch yourself based on the current implementation.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bfcfbfe0dacfc3ee5a6601a4f85f206309fc09de commit bfcfbfe0dacfc3ee5a6601a4f85f206309fc09de Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2021-01-28 12:45:02 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2021-01-28 12:45:02 +0000 media-gfx/valentina: patched out vcs calls in 0.6.1-r1 Closes: https://bugs.gentoo.org/762601 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> .../valentina-0.6.1-disable-vcs-version.patch | 75 ++++++++++++++++++++++ media-gfx/valentina/valentina-0.6.1-r1.ebuild | 3 +- 2 files changed, 77 insertions(+), 1 deletion(-)
