Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762421 - net-misc/openntpd: please provide support for dev-libs/libretls
Summary: net-misc/openntpd: please provide support for dev-libs/libretls
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paul B. Henson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 762847
  Show dependency tree
 
Reported: 2020-12-29 12:12 UTC by Michał Górny
Modified: 2021-01-05 21:20 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-12-29 12:12:09 UTC 
FWICS the package builds just fine against dev-libs/libretls in place of libressl.  Please provide a support for it, and replace the wrong use of USE=libretls with a dedicated flag for the feature (and USE=libressl to switch between libretls and libressl).
Comment 1 Paul B. Henson 2020-12-30 00:09:53 UTC 
So you want a use flag like "constraints" or something to control whether or not they are enabled and libretls is required?

Based on the devel list, it sounds like libressl is on the way out, so should I just remove that flag completely?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-12-30 00:42:26 UTC 
(In reply to Paul B. Henson from comment #1)
> So you want a use flag like "constraints" or something to control whether or
> not they are enabled and libretls is required?

Yes.

> Based on the devel list, it sounds like libressl is on the way out, so
> should I just remove that flag completely?

You can use dev-libs/libretls instead.  It seems to work just fine.
Comment 3 Paul B. Henson 2020-12-30 00:47:31 UTC 
Ok, so ditch the libressl use flag and add a "constraints" use flag which if enabled will depend on libretls. I'll take a look at it, thanks.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-12-30 08:29:52 UTC 
For the time being, probably something like that would be a good idea:

  constraints? (
    libressl? ( dev-libs/libressl:= )
    !libressl? ( dev-libs/libretls:= )
  )

At least until we factually start removing LibreSSL.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-05 16:38:41 UTC 
Paul, could you review the linked PR, please?
Comment 6 Paul B. Henson 2021-01-05 20:49:08 UTC 
Sorry, I guess I was confused, I thought you had already committed it to the repo. Looks good to me, thanks much...
Comment 7 Larry the Git Cow gentoo-dev 2021-01-05 21:20:21 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d23cdc46ebda3861e5a9478f9e4d7c028b54a01

commit 2d23cdc46ebda3861e5a9478f9e4d7c028b54a01
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-01-01 11:40:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-01-05 21:19:32 +0000

    net-misc/openntpd: Support dev-libs/libretls
    
    Closes: https://bugs.gentoo.org/762421
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/18895
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-misc/openntpd/metadata.xml              |  1 +
 net-misc/openntpd/openntpd-6.8_p1-r1.ebuild | 67 +++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)