Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762382 - sys-devel/gcc-10.2.0-r[234]: bad parse a result of PR95820 patch -- better than ICE
Summary: sys-devel/gcc-10.2.0-r[234]: bad parse a result of PR95820 patch -- better th...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gcc-10
  Show dependency tree
 
Reported: 2020-12-29 09:22 UTC by Daniel Santos
Modified: 2020-12-29 18:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Santos 2020-12-29 09:22:14 UTC
I've opened an upstream report and I had to figure out how it was affecting gcc-10.  I didn't realize you guys were so sharp on backports! :D

So I guess this fix also results in a bad parse on some code: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98441

So might want to add to #gcc-10 tracker.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-12-29 09:49:26 UTC
If our backport causes bad parsing we'll need to drop the backport. It was supposed to only fix ICE-on-invalid.
Comment 2 Larry the Git Cow gentoo-dev 2020-12-29 09:55:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=7adab39a82fd07085f600603bdc5c440aa1c142a

commit 7adab39a82fd07085f600603bdc5c440aa1c142a
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-12-29 09:51:52 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-12-29 09:51:52 +0000

    10.2.0: revert PR95820 backporting
    
    The backport breaks parsing as seen in https://gcc.gnu.org/PR98441
    
    Bug: https://gcc.gnu.org/PR95820
    Bug: https://bugs.gentoo.org/730406
    Reported-by: Daniel Santos
    Bug: https://gcc.gnu.org/PR98441
    Bug: https://bugs.gentoo.org/762382
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 10.2.0/gentoo/34_all_fundecl-ICE-PR95820.patch | 25 -------------------------
 10.2.0/gentoo/README.history                   |  3 +++
 2 files changed, 3 insertions(+), 25 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2020-12-29 10:07:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=3779ee05e8c035d435c62198f3b761516e63fdf0

commit 3779ee05e8c035d435c62198f3b761516e63fdf0
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-12-29 10:05:50 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-12-29 10:05:50 +0000

    10.2.0: cut 6 patchset
    
    Single dropped patch:
    - 34_all_fundecl-ICE-PR95820.patch: revert PR95820 backporting
    
    Bug: https://gcc.gnu.org/PR95820
    Bug: https://bugs.gentoo.org/730406
    Reported-by: Daniel Santos
    Bug: https://gcc.gnu.org/PR98441
    Bug: https://bugs.gentoo.org/762382
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 10.2.0/gentoo/README.history | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2020-12-29 10:14:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8667621e1a1fb7684b9b8d112255f33f8d5ec978

commit 8667621e1a1fb7684b9b8d112255f33f8d5ec978
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-12-29 10:11:31 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-12-29 10:14:44 +0000

    sys-devel/gcc: 10.2.0: cut 6 patchset
    
    Single dropped patch:
    - 34_all_fundecl-ICE-PR95820.patch: revert PR95820 backporting
    
    Bug: https://gcc.gnu.org/PR95820
    Bug: https://bugs.gentoo.org/730406
    Reported-by: Daniel Santos
    Bug: https://gcc.gnu.org/PR98441
    Closes: https://bugs.gentoo.org/762382
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/gcc/Manifest             |  1 +
 sys-devel/gcc/gcc-10.2.0-r5.ebuild | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
Comment 5 Daniel Santos 2020-12-29 18:25:20 UTC
Wow, fast resolution!  I'll keep an eye on the upstream bug and let you know when there's an updated patch.