Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762268 - media-sound/bluez-alsa: enable aptX support via openaptx or libopenaptx
Summary: media-sound/bluez-alsa: enable aptX support via openaptx or libopenaptx
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: https://github.com/Arkq/bluez-alsa, h...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-28 17:08 UTC by sphakka
Modified: 2021-06-09 11:42 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sphakka 2020-12-28 17:08:38 UTC
According to bluez-alsa's home page, aptX is supported via the extra library `openaptx` by the same author. It would be nice to have.

Please note, it looks like openaptx:

* uses reverse-engineered code => possible licence issues;
* relies on ffmpeg's aptX support which seems not available in Gentoo's ebuild.

An alternative might be Pali's `libopenaptx` (see also Bug 758377), though that's work in progress: <https://github.com/Arkq/bluez-alsa/pull/356>.

Reproducible: Always
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-12 00:52:30 UTC
This looks like it definitely would cause license issues. CCing license team.
Comment 2 Ulrich Müller gentoo-dev 2021-01-12 08:35:25 UTC
Looks like the project is distributed under the MIT license. If the algorithm is affected by software patents, then it cannot be distributed in binary form (at least not in countries where it is patented). Commercial use may also be problematic.

IIUC distribution of source code shouldn't be a problem, so the only thing needed would be a bindist restriction.

Disclaimer: I am not a lawyer. This is not legal advice.
Comment 3 Atman Sense 2021-03-07 11:23:47 UTC
Tried with this ebuild:
```
EAPI=7
inherit cmake-utils

DESCRIPTION="reverse-engineered apt-X audio codec"
HOMEPAGE="https://github.com/Arkq/openaptx"

if [[ ${PV} == "9999" ]] ; then
    inherit git-r3
    EGIT_REPO_URI="https://github.com/Arkq/${PN}"
else
    SRC_URI="https://github.com/Arkq/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"
    KEYWORDS="~amd64 ~x86"
fi

LICENSE="MIT"
SLOT="0"
```
And got aptX working only when built with
`MYCMAKEARGS="-DWITH_FFMPEG=ON" emerge openaptx -v1` 
(and `EXTRA_ECONF="--enable-aptx" emerge -v1 media-sound/bluez-alsa`).
Without `-DWITH_FFMPEG=ON` I got a loud annoying noise instead of sound.

Tried with libopenaptx and `EXTRA_ECONF="--with-libopenaptx"` also, but aptX wasn't detected at all.
Comment 4 Joakim Tjernlund 2021-03-18 02:15:35 UTC
openaptx is in Gentoo tree now
Comment 5 Larry the Git Cow gentoo-dev 2021-05-24 17:42:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07fea7a07c766c5ad034200209cd00f48f562450

commit 07fea7a07c766c5ad034200209cd00f48f562450
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-05-24 17:39:52 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-05-24 17:42:47 +0000

    media-sound/bluez-alsa: Added aptx support
    
    Bug: https://bugs.gentoo.org/762268
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 media-sound/bluez-alsa/bluez-alsa-9999.ebuild | 7 +++++--
 media-sound/bluez-alsa/metadata.xml           | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-05-24 17:45:09 UTC
This is in the live ebuild for now because we only have media-libs/libopenaptx and support for that lib is not in the 3.0.0 release.
Once bluez-alsa rolls a new release, aptx support will be available there.
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-06-09 11:42:10 UTC
commit c4967e60c5f845596d70a690dfdda5261de55ba4
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Jun 9 09:32:03 2021

    media-sound/bluez-alsa: Bump to version 3.1.0

    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>