Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762208 - games-emulation/vbam-2.1.4 : /.../SDL.cpp: error: KMOD_META was not declared in this scope
Summary: games-emulation/vbam-2.1.4 : /.../SDL.cpp: error: KMOD_META was not declared ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-28 11:27 UTC by Toralf Förster
Modified: 2021-03-09 08:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.18 KB, text/plain)
2020-12-28 11:27 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,254.09 KB, text/plain)
2020-12-28 11:27 UTC, Toralf Förster
Details
environment (environment,94.75 KB, text/plain)
2020-12-28 11:27 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,47.97 KB, application/x-bzip)
2020-12-28 11:27 UTC, Toralf Förster
Details
games-emulation:vbam-2.1.4:20201228-110847.log (games-emulation:vbam-2.1.4:20201228-110847.log,19.07 KB, text/plain)
2020-12-28 11:27 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,6.95 KB, application/x-bzip)
2020-12-28 11:27 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,26.01 KB, application/x-bzip)
2020-12-28 11:27 UTC, Toralf Förster
Details
SDL2.patch (SDL2.patch,477 bytes, patch)
2021-02-20 13:19 UTC, nvinson234
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-12-28 11:27:02 UTC
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/sdl/SDL.cpp: In function ‘void sdlPollEvents()’:
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/sdl/SDL.cpp:884:45: error: ‘KMOD_META’ was not declared in this scope; did you mean ‘KMOD_ALT’?
  884 | #define MOD_NOCTRL (KMOD_SHIFT | KMOD_ALT | KMOD_META)
      |                                             ^~~~~~~~~
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/sdl/SDL.cpp:1057:46: note: in expansion of macro ‘MOD_NOCTRL’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20201219-003732

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.0.0
Available Python interpreters, in order of preference:
  [1]   python3.9
  [2]   python3.8 (fallback)
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems)
  [2]   ruby26 (with Rubygems)
  [3]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.48.0 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.272_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.8.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Mon Dec 28 09:35:20 AM UTC 2020

emerge -qpvO games-emulation/vbam
[ebuild  N    ] games-emulation/vbam-2.1.4  USE="nls sdl wxwidgets -ffmpeg -link -lirc -openal"
Comment 1 Toralf Förster gentoo-dev 2020-12-28 11:27:03 UTC
Created attachment 680014 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-12-28 11:27:05 UTC
Created attachment 680017 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-12-28 11:27:07 UTC
Created attachment 680020 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-12-28 11:27:08 UTC
Created attachment 680023 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-12-28 11:27:09 UTC
Created attachment 680026 [details]
games-emulation:vbam-2.1.4:20201228-110847.log
Comment 6 Toralf Förster gentoo-dev 2020-12-28 11:27:10 UTC
Created attachment 680029 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-12-28 11:27:11 UTC
Created attachment 680032 [details]
temp.tbz2
Comment 8 nvinson234 2021-02-20 13:19:23 UTC
Created attachment 687738 [details, diff]
SDL2.patch

SDL2@2.0.14 changed KMOD_GUI from a macro to an enum.

This patch checks for that change when defining KMOD_META.
Comment 9 nvinson234 2021-02-21 02:23:37 UTC
bug submitted upstream as well.  Link: https://github.com/visualboyadvance-m/visualboyadvance-m/issues/815
Comment 10 Larry the Git Cow gentoo-dev 2021-03-09 08:46:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=117f6634d01f2c89e614561de47351c9bdfef37a

commit 117f6634d01f2c89e614561de47351c9bdfef37a
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-03-09 08:46:17 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-03-09 08:46:17 +0000

    games-emulation/vbam: Fixed build against libsdl2-2.0.14
    
    Closes: https://bugs.gentoo.org/762208
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../vbam/files/vbam-2.1.4-libsdl2-2.0.14.patch     | 27 ++++++++++++++++++++++
 games-emulation/vbam/vbam-2.1.4.ebuild             |  3 ++-
 2 files changed, 29 insertions(+), 1 deletion(-)