Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 761849 - dev-python/adblock-0.4.3 (new package)
Summary: dev-python/adblock-0.4.3 (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Stefan Strogin
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2020-12-27 02:16 UTC by Marco Rebhan
Modified: 2021-06-23 11:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adblock-0.4.0.ebuild (adblock-0.4.0.ebuild,3.54 KB, text/plain)
2020-12-27 02:17 UTC, Marco Rebhan
Details
dev-python/adblock-0.4.1 (adblock-0.4.1.ebuild,3.49 KB, text/plain)
2021-01-28 15:53 UTC, Marco Rebhan
Details
adblock-0.4.3.ebuild (adblock-0.4.3.ebuild,2.63 KB, patch)
2021-03-21 21:28 UTC, Marco Rebhan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Rebhan 2020-12-27 02:16:36 UTC
This includes dev-python/adblock-0.4.0, a package which provides bindings for Brave's adblock library for Python. This will be an optional dependency for www-client/qutebrowser with probably its next release, to provide advanced adblocking functionality in the browser using AdBlock Plus lists. See https://github.com/qutebrowser/qutebrowser/pull/5317 for more details.
Comment 1 Marco Rebhan 2020-12-27 02:17:13 UTC
Created attachment 679784 [details]
adblock-0.4.0.ebuild
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-12-27 02:52:06 UTC
CCing qutebrowser maintainers in case they're interested.
Comment 3 Marco Rebhan 2021-01-28 15:53:09 UTC
Updated the ebuild to version 0.4.1. Also, qutebrowser 2.0.0 has now been released which can actually use this package as an optional dependency.
Comment 4 Marco Rebhan 2021-01-28 15:53:52 UTC
Created attachment 684984 [details]
dev-python/adblock-0.4.1
Comment 5 Marco Rebhan 2021-03-21 21:28:51 UTC
Created attachment 692823 [details, diff]
adblock-0.4.3.ebuild
Comment 6 Larry the Git Cow gentoo-dev 2021-06-22 21:37:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2989652366b2239e827f4279426b4cdffb75092c

commit 2989652366b2239e827f4279426b4cdffb75092c
Author:     Stefan Strogin <steils@gentoo.org>
AuthorDate: 2021-06-22 21:05:23 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2021-06-22 21:34:10 +0000

    dev-python/adblock: add new package
    
    Closes: https://bugs.gentoo.org/761849
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 dev-python/adblock/Manifest             |  66 +++++++++++++++++++
 dev-python/adblock/adblock-0.4.4.ebuild | 112 ++++++++++++++++++++++++++++++++
 dev-python/adblock/metadata.xml         |   8 +++
 3 files changed, 186 insertions(+)
Comment 7 Stefan Strogin gentoo-dev 2021-06-22 21:41:18 UTC
Hi Marco. Thanks for the bug and for the ebuild.
I added dev-util/maturin, so now this package can be built the way intended by the author. And the ebuild now is a little simpler. If you find any issues please tell about them.
Comment 8 Marco Rebhan 2021-06-23 07:02:48 UTC
(In reply to Stefan Strogin from comment #7)
> Hi Marco. Thanks for the bug and for the ebuild.
> I added dev-util/maturin, so now this package can be built the way intended
> by the author. And the ebuild now is a little simpler. If you find any
> issues please tell about them.

Thanks! I am wondering though, how did you get rid of the patch to make psl-codegen not download files when building? This version obviously builds fine without the patch, but not when I originally wrote it.
Comment 9 Stefan Strogin gentoo-dev 2021-06-23 11:26:58 UTC
Not sure. Maybe something changed in the upstream between 0.4.3 and 0.4.4 (and corresponding crates' versions). I just doesn't try to download anything in build-time (for me).