Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 761535 - media-video/vlc-3.0.11.1-r100 USE=-lua, but lua-single.eclass complaining about unset LUA_SINGLE_TARGET
Summary: media-video/vlc-3.0.11.1-r100 USE=-lua, but lua-single.eclass complaining abo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-24 23:14 UTC by Duncan
Modified: 2020-12-25 00:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2020-12-24 23:14:48 UTC
So nominally this is a bug in the vlc ebuild, but arguably it's really a bug in lua-single.eclass.

Surface problem: USE=-lua emerge =media-video/vlc-3.0.11.1-r100 fails with the following:

* No Lua implementation selected for the build. Please set
* the LUA_SINGLE_TARGET variable in your make.conf to one
* of the following values:
*
* lua5-1 lua5-2
* ERROR: media-video/vlc-3.0.11.1-r100::gentoo failed (setup phase):
*   No supported Lua implementation in LUA_SINGLE_TARGET.
*
* Call stack:
*           ebuild.sh, line 125:  Called pkg_setup
*           ebuild.sh, line 355:  Called lua-single_pkg_setup
*   lua-single.eclass, line 536:  Called lua_setup
*   lua-single.eclass, line 526:  Called die
* The specific snippet of code:
*              die "No supported Lua implementation in LUA_SINGLE_TARGET."

Note the USE=-lua:  Why is it asking me to set LUA_SINGLE_TARGET when a lua isn't pulled in?

AFAICT the nominal solution would be a pkg_setup like this:

pkg_setup() {
     use lua && lua-single_pkg_setup
}

However, it seems to me a better solution would be to have lua-single.eclass make that LUA_SINGLE_TARGET test conditional on some LUA* var (presently in the eclass or if necessary new) set by the ebuild.  Then ebuilds using it wouldn't have to override its exported pkg_setup just to add the conditional.

(I searched existing bugs for both the vlc...-r100 and lua-single.eclass and didn't find an existing bug.  Hopefully I didn't miss one, tho of course this and another could be being filed at the same time.)
Comment 1 Larry the Git Cow gentoo-dev 2020-12-25 00:24:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2140581df4f203a1b4e8c21c38cfe7e64f45513d

commit 2140581df4f203a1b4e8c21c38cfe7e64f45513d
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-12-25 00:23:51 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-12-25 00:23:51 +0000

    media-video/vlc: avoid calling lua-single_pkg_setup when USE='-lua'
    
    Closes: https://bugs.gentoo.org/761535
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 media-video/vlc/vlc-3.0.11.1-r100.ebuild | 6 ++++++
 media-video/vlc/vlc-3.0.9999.ebuild      | 6 ++++++
 media-video/vlc/vlc-9999.ebuild          | 6 ++++++
 3 files changed, 18 insertions(+)