Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 761316 - x11-misc/safeeyes: Add 'libnotify' as a dependency.
Summary: x11-misc/safeeyes: Add 'libnotify' as a dependency.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-23 03:44 UTC by Utkarsh Verma
Modified: 2020-12-26 15:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Utkarsh Verma 2020-12-23 03:44:59 UTC
I had to manually install 'x11-libs/libnotify' to get notifications to work. Please consider adding it as a dependency or as a USE flag.
Comment 1 Sebastian Pipping gentoo-dev 2020-12-23 16:34:15 UTC
Hi Utkarsh,

please help me understand the situation better.  Is this specific to XFCE, are you running XFCE?  What kind of notifications are you referring to?  All I find upstream is this: https://github.com/slgobinath/SafeEyes/search?q=libnotify&type=issues .  Thanks in advance!

Best, Sebastian
Comment 2 Utkarsh Verma 2020-12-23 17:37:32 UTC
Hi Sebastian,
I've observed this on KDE. If I don't install 'libnotify', then the notification plugin fails to load.
This is the line of code which depends on it:
https://github.com/slgobinath/SafeEyes/blob/master/safeeyes/plugins/notification/plugin.py#L24
Comment 3 Sebastian Pipping gentoo-dev 2020-12-23 19:43:36 UTC
Thanks for your detailed reply and the link!

Based on ..

  # git --no-pager grep -h require_version | sort -u
  gi.require_version('AppIndicator3', '0.1')
  gi.require_version('Gdk', '3.0')
  gi.require_version('Gtk', '3.0')
  gi.require_version('Notify', '0.7')

.. it seems to me that we should add all of these as runtime dependencies:

  dev-libs/libappindicator[introspection]:3
  x11-libs/gtk+[introspection]:3
  x11-libs/libnotify[introspection]

What do you think?
Comment 4 Sebastian Pipping gentoo-dev 2020-12-23 19:44:39 UTC
My bad, second take:

  dev-libs/libappindicator:3[introspection]
  x11-libs/gtk+:3[introspection]
  x11-libs/libnotify[introspection]
Comment 5 Utkarsh Verma 2020-12-25 05:27:37 UTC
Hi Sebastian,
Thanks for looking further into this. I think these dependencies should be fine. Some USE flags could be used to mark out these dependencies in case the user doesn't use these plugins. By default, these libs should be installed though.
Comment 6 Larry the Git Cow gentoo-dev 2020-12-26 15:56:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c23770271229055dce9c4687e5057c1070ef143

commit 2c23770271229055dce9c4687e5057c1070ef143
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2020-12-26 15:51:41 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2020-12-26 15:52:40 +0000

    x11-misc/safeeyes: 2.1.1 + add missing deps
    
    Closes: https://bugs.gentoo.org/761316
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.12, Repoman-3.0.2

 x11-misc/safeeyes/Manifest                         |  1 +
 ...es-2.0.9-r1.ebuild => safeeyes-2.0.9-r2.ebuild} |  4 +-
 x11-misc/safeeyes/safeeyes-2.1.1.ebuild            | 51 ++++++++++++++++++++++
 3 files changed, 55 insertions(+), 1 deletion(-)