Dropped ~amd64-linux ~x86-linux.
Are you reporting this for the sake of reporting this, or do you need those keywords? FYI I did see them getting dropped, but considered that as "cleaning" and nothing errorneous. If you need them, just add them back...
I removed this keywords because I don't run a prefix system to test them and I didn't know what to do with these flags... is there a documentation what to do when bumping ebuilds with these flags (I quickly search but without success). am I allowed to keep them even without testing it?
In general, this follows normal keywording rules: - if you bump, keep the keywords - if the bump introduces a new unkeyworded dependency, drop the keywords, file a bug - if you bump, and the package is something like a complete rewrite, or very significant changes, drop the keywords and file a bug In this case I don't know why the package was prefix-keyworded, and if anyone is using it at all. This is very specific to Prefix, and the capacity of the Prefix team: I'd rather loose the keywords here so we don't have to bother testing etc. We don't have tinderboxen running for Prefix. So, @sam, why did you file this bug? If it is just because our keywords were dropped, which normally would be indeed a reason to file a bug, then I think the better approach is to de-keyword git-cola completely. If you're using it, or know people who do, then we should just keyword it. Final note, amd64-linux and x86-linux are VERY similar to amd64 and x86. In fact they are scheduled to go away, so as a rule of thumb, if it compiles on amd64, it compiles on amd64-linux too. (Which is the reason for removing the latter keyword.)
(In reply to Martin Gysel (bearsh) from comment #2) > I removed this keywords because I don't run a prefix system to test them and > I didn't know what to do with these flags... > > is there a documentation what to do when bumping ebuilds with these flags (I > quickly search but without success). am I allowed to keep them even without > testing it? I think grobian has explained this well. The gist is that you should drop back to ~ for all arches when bumping but not drop keywords unless you're in one of the cases he mentions; in which case, file a bug for rekeywording. If you meant to drop support for an arch, ideally have a reason but also drop it from all versions so that we don't get a warning (which led to me filing this bug). No worries, it happens a lot, which is what I'm hoping to reduce. :) https://devmanual.gentoo.org/keywording/index.html (In reply to Fabian Groffen from comment #3) > [...] > So, @sam, why did you file this bug? If it is just because our keywords > were dropped, which normally would be indeed a reason to file a bug, then I > think the better approach is to de-keyword git-cola completely. If you're > using it, or know people who do, then we should just keyword it. > Exactly. Part of it is to correct a misunderstanding. A lot of the time, it ends up being dropped because somebody misunderstood - so if somebody learns something, I think it's fulfilled its purpose. That, and I want to try get the depgraph more consistent + ensure we have the latest versions keyworded. There is no way through automation to figure out if someone meant to drop keywords (in which case, everything should be dropped) or it was accidental, so this is how I've been trying to find out. > Final note, amd64-linux and x86-linux are VERY similar to amd64 and x86. In > fact they are scheduled to go away, so as a rule of thumb, if it compiles on > amd64, it compiles on amd64-linux too. (Which is the reason for removing > the latter keyword.) Yes, I think in such cases I'm just going to unilaterally restore/kill depending on likelihood of it being used if there's no signs. In this case, I'll drop them all.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2627d2aaadd4e414ac5e662533e600c8e64244c2 commit 2627d2aaadd4e414ac5e662533e600c8e64244c2 Author: Sam James <sam@gentoo.org> AuthorDate: 2020-12-21 19:58:10 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2020-12-21 19:58:10 +0000 dev-vcs/git-cola: fully drop prefix keywords Let us know if you want to use this and we can restore them. Closes: https://bugs.gentoo.org/760806 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Sam James <sam@gentoo.org> dev-vcs/git-cola/git-cola-3.5-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
