Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 760060 - dev-libs/libratbag-0.15 fails to compile
Summary: dev-libs/libratbag-0.15 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alex Barker
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-15 09:26 UTC by Agostino Sarubbo
Modified: 2020-12-15 18:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,9.87 KB, text/plain)
2020-12-15 09:26 UTC, Agostino Sarubbo
Details
libratbag-0.15-r1.patch (libratbag.patch,334 bytes, patch)
2020-12-15 17:43 UTC, Alex Barker
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-12-15 09:26:32 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/libratbag-0.15 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2020-12-15 09:26:34 UTC
Created attachment 678373 [details]
build.log

build log and emerge --info
Comment 2 Alex Barker 2020-12-15 17:43:30 UTC
Created attachment 678400 [details, diff]
libratbag-0.15-r1.patch

Patch file to add missing depend dev-libs/check.  Should resolve the issue, tested with FEATURES=test.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-15 17:50:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0452a7ff0e3186a02a4d634b39f664e9ecb4c72

commit c0452a7ff0e3186a02a4d634b39f664e9ecb4c72
Author:     Alexander Barker <alex@1stleg.com>
AuthorDate: 2020-12-15 17:48:26 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-12-15 17:50:28 +0000

    dev-libs/libratbag: Add dev-libs/check to BDEPEND
    
    Closes: https://bugs.gentoo.org/760060
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 dev-libs/libratbag/libratbag-0.15.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Arfrever Frehtes Taifersar Arahesis 2020-12-15 17:57:10 UTC
> Found CMake: /usr/bin/cmake (3.19.1)
> Run-time dependency check found: NO (tried pkgconfig and cmake)
> 
> meson.build:371:1: ERROR: Dependency "check" not found, tried pkgconfig and cmake

This fragment shows that dev-libs/check is needed in DEPEND, not BDEPEND.

(dev-libs/check very rarely is needed in BDEPEND, only when /usr/bin/checkmk is called.)
Comment 5 Alex Barker 2020-12-15 18:01:49 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4)
> > Found CMake: /usr/bin/cmake (3.19.1)
> > Run-time dependency check found: NO (tried pkgconfig and cmake)
> > 
> > meson.build:371:1: ERROR: Dependency "check" not found, tried pkgconfig and cmake
> 
> This fragment shows that dev-libs/check is needed in DEPEND, not BDEPEND.
> 
> (dev-libs/check very rarely is needed in BDEPEND, only when /usr/bin/checkmk
> is called.)

It's possible that I don't understand something, but I think this is only required for testing at build time so why DEPEND over BDEPEND?
Comment 6 Arfrever Frehtes Taifersar Arahesis 2020-12-15 18:40:03 UTC
(In reply to Alex Barker from comment #5)
> (In reply to Arfrever Frehtes Taifersar Arahesis from comment #4)
> > > Found CMake: /usr/bin/cmake (3.19.1)
> > > Run-time dependency check found: NO (tried pkgconfig and cmake)
> > > 
> > > meson.build:371:1: ERROR: Dependency "check" not found, tried pkgconfig and cmake
> > 
> > This fragment shows that dev-libs/check is needed in DEPEND, not BDEPEND.
> > 
> > (dev-libs/check very rarely is needed in BDEPEND, only when /usr/bin/checkmk
> > is called.)
> 
> It's possible that I don't understand something, but I think this is only
> required for testing at build time so why DEPEND over BDEPEND?

Both BDEPEND and DEPEND are build-time dependencies.

BDEPEND should contain packages installed in ${BROOT} which provide e.g.:
- Executables called at build time
- Python modules imported at build time

DEPEND should contain packages installed in ${SYSROOT} which provide e.g.:
- C/C++ headers/libraries used at build time
- .pc files used by pkg-config