Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 760048 - x11-misc/rofi-1.6.1 fails tests
Summary: x11-misc/rofi-1.6.1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Petrus Zhao
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2020-12-15 07:36 UTC by Agostino Sarubbo
Modified: 2021-10-12 08:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,356.01 KB, text/plain)
2020-12-15 07:36 UTC, Agostino Sarubbo
Details
1-test-suite.log (1-test-suite.log,590 bytes, text/plain)
2020-12-15 07:37 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-12-15 07:36:56 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/rofi-1.6.1 fails tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2020-12-15 07:36:59 UTC
Created attachment 678358 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-12-15 07:37:00 UTC
Created attachment 678361 [details]
1-test-suite.log

1-test-suite.log
Comment 3 Petrus Zhao 2021-10-10 16:39:35 UTC
Hi,

I found out it failed beacause of missing x11-misc/xkeyboard-config.

I can add it to rofi ebuld, but I think it better to add it as a x11-libs/libxkbcommon dependency, and control it by USE flag.

I also found a similar bug on freebsd's Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229127
Comment 4 Petrus Zhao 2021-10-12 02:28:24 UTC
I think I can add x11-misc/xkeyboard-config to rofi dependency first.
Comment 5 Larry the Git Cow gentoo-dev 2021-10-12 08:13:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ec5ef691d6bdaf618821e79b00772806e0311d5

commit 2ec5ef691d6bdaf618821e79b00772806e0311d5
Author:     Petrus.Z <silencly07@gmail.com>
AuthorDate: 2021-10-12 07:53:29 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2021-10-12 08:12:57 +0000

    x11-misc/rofi: add missing x11-misc/xkeyboard-config dependency
    
    Add the missing x11-misc/xkeyboard-config dependency.
    This fixes test failures reported by the tinderbox.
    Bump 1.6.1 to 1.6.1-r1, and bump 1.7.0 to 1.7.0-r1, drop
    old non-r1 ebuilds.
    
    Closes: https://bugs.gentoo.org/760048
    Package-Manager: Portage-3.0.26, Repoman-3.0.3
    Signed-off-by: Petrus Zhao <petrus.zy.07@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/22561
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 x11-misc/rofi/{rofi-1.6.1.ebuild => rofi-1.6.1-r1.ebuild} | 1 +
 x11-misc/rofi/{rofi-1.7.0.ebuild => rofi-1.7.0-r1.ebuild} | 1 +
 x11-misc/rofi/rofi-99999.ebuild                           | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)