Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 760006 - media-video/subtitlecomposer-0.7.0[mpv] with media-video/mpv-0.33.0 fails to build
Summary: media-video/subtitlecomposer-0.7.0[mpv] with media-video/mpv-0.33.0 fails to ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-14 13:25 UTC by Julien Papasian
Modified: 2020-12-25 19:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Papasian 2020-12-14 13:25:26 UTC
Error message is:
fatal error: mpv/qthelper.hpp: No such file or directory

To fix compilation against newer versions of mpv, we need this patch:
https://aur.archlinux.org/cgit/aur.git/tree/0001-fix-mpv-compile.patch?h=subtitlecomposer

Upstream issue is here: https://invent.kde.org/multimedia/subtitlecomposer/-/issues/30

Best is probably to keep two ebuilds:
- Add mpv < 0.33 restriction to the current 0.7.0 ebuild
- Add new ebuild 0.7.0-r1 with the patch.

Reproducible: Always
Comment 1 Andreas Sturmlechner gentoo-dev 2020-12-25 19:31:01 UTC
Please note that mpv option is already dropped from git master, so I'm a bit weary to keep fixing it.
Comment 2 Larry the Git Cow gentoo-dev 2020-12-25 19:54:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b598cbac8677e292b34b62104620e072fe9acf43

commit b598cbac8677e292b34b62104620e072fe9acf43
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-25 19:54:21 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-25 19:54:35 +0000

    media-video/subtitlecomposer: Fix build with >=media-video/mpv-0.33
    
    Reported-by: Julien Papasian <julien.papasian@gmail.com>
    Closes: https://bugs.gentoo.org/760006
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/subtitlecomposer-0.7.0-mpv-0.33.patch    | 260 +++++++++++++++++++++
 .../subtitlecomposer/subtitlecomposer-0.7.0.ebuild |   1 +
 2 files changed, 261 insertions(+)