Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759802 - dev-libs/aws-c-io-0.7.0 fails tests
Summary: dev-libs/aws-c-io-0.7.0 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sven Eden
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-13 14:24 UTC by Agostino Sarubbo
Modified: 2021-01-05 09:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,69.92 KB, text/plain)
2020-12-13 14:24 UTC, Agostino Sarubbo
Details
1-LastTest.log.xz (1-LastTest.log.xz,126.75 KB, application/x-xz)
2020-12-13 14:24 UTC, Agostino Sarubbo
Details
emerge --info (emerge_info_sed.txt,22.29 KB, text/plain)
2020-12-15 08:35 UTC, Sven Eden
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-12-13 14:24:46 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/aws-c-io-0.7.0 fails tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2020-12-13 14:24:49 UTC
Created attachment 678229 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-12-13 14:24:52 UTC
Created attachment 678232 [details]
1-LastTest.log.xz

1-LastTest.log (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 3 Sven Eden 2020-12-14 19:56:27 UTC
I have to take a look. All tests work fine for me.

--------
USE="test" ebuild aws-c-io-0.7.0.ebuild test
(...)
100% tests passed, 0 tests failed out of 149

Total Test time (real) =  28.80 sec
 * Tests succeeded.
>>> Completed testing dev-libs/aws-c-io-0.7.0
--------

That's what I see...
Comment 4 Sven Eden 2020-12-14 20:47:49 UTC
If your machine isn't online, all internet connectivity tests willl fail, yes.

PR submitted with new USE flag "net-tests" to opt-in on internet connectivity tests.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-12-15 04:04:54 UTC
(In reply to Sven Eden from comment #3)
> I have to take a look. All tests work fine for me.
> 
> --------
> USE="test" ebuild aws-c-io-0.7.0.ebuild test
> (...)
> 100% tests passed, 0 tests failed out of 149
> 
> Total Test time (real) =  28.80 sec
>  * Tests succeeded.
> >>> Completed testing dev-libs/aws-c-io-0.7.0
> --------
> 
> That's what I see...

emerge --info please?
Comment 6 Sven Eden 2020-12-15 08:34:15 UTC
As I wrote as an answer to your review, tests work fine if performed as a regular user using the ebuild command, even with enabled net-tests.

I can unconditionally disable them, or add an explanation to metadata.xml, that enabling net-tests will fail regular testing via `emerge` if network-sandbox is enabled. (Which it always should)
Comment 7 Sven Eden 2020-12-15 08:35:46 UTC
Created attachment 678367 [details]
emerge --info

emerge --info as requested.
Comment 8 Larry the Git Cow gentoo-dev 2021-01-05 09:06:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e81304b543febf538717b560e6cd821c6131a3e

commit 0e81304b543febf538717b560e6cd821c6131a3e
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-12-14 20:10:07 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-05 09:06:29 +0000

    dev-libs/aws-c-io: Disable tests requiring an internet connection
    
    Some of the tests require internet connectivity. On an offline
    machine these tests will therefore fail.
    
    As network sandboxing is enabled by default for years now, it is
    very unlikely that anybody would perform these tests anyway.
    
    Closes: https://bugs.gentoo.org/759802
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Closes: https://github.com/gentoo/gentoo/pull/18656
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../{aws-c-io-0.7.0.ebuild => aws-c-io-0.7.0-r1.ebuild}      | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)