Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759418 - app-misc/pdfpc with USE +gstreamer should (maybe?) depend on gst-plugins-gtk and gst-plugins-cairo
Summary: app-misc/pdfpc with USE +gstreamer should (maybe?) depend on gst-plugins-gtk ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Nils Freydank
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-10 21:27 UTC by William Pettersson
Modified: 2021-01-18 09:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Pettersson 2020-12-10 21:27:07 UTC
pdfpc supports its own particular method of inserting media into presentations (see an example by downloading https://github.com/pdfpc/pdfpc/releases/latest/download/pdfpc-video-example.zip). When such files are viewed in pdfpc, pdfpc uses gstreamer to create a gtksink and a cairooverlay  (see https://github.com/pdfpc/pdfpc/blob/master/src/classes/action/movie.vala lines 682 and 800). These are found in media-plugins/gst-plugins-gtk and media-plugins/gst-plugins-cairo respectively. Without them, pdfpc will still run, but won't show videos. It will print error messages in a terminal if one is attached, but otherwise the error is silent.

I assume that the gstreamer USE flag is meant for enabling this feature, but it's missing these as RDEPENDS. Note that they are not required for building, just at runtime. The specific plugins have also changed in recent years, so it may be that in the past, gst-plugins-base was sufficient.

If the gstreamer USE flag has some other intention for pdfpc, then maybe another USE flag is required.
Comment 1 Nils Freydank 2020-12-19 21:22:34 UTC
Hi William,

you're right, fix is queued - thanks alot for your detailed report!
Comment 2 Larry the Git Cow gentoo-dev 2021-01-18 09:28:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a76178c2473a98a17dfa3a5de21f95718d4a634

commit 3a76178c2473a98a17dfa3a5de21f95718d4a634
Author:     Nils Freydank <holgersson@posteo.de>
AuthorDate: 2021-01-18 09:26:48 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-18 09:27:53 +0000

    app-misc/pdfpc: Bump to 4.4.1
    
    This ebuild also enables support for vala:0.50 and adds missing deps
    for gstreamer.
    
    Closes: https://bugs.gentoo.org/759418
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Nils Freydank <holgersson@posteo.de>
    Closes: https://github.com/gentoo/gentoo/pull/18729
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-misc/pdfpc/Manifest           |  1 +
 app-misc/pdfpc/pdfpc-4.4.1.ebuild | 51 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)