Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759004 - dev-vcs/git: Emacs needs to be moved to BDEPEND
Summary: dev-vcs/git: Emacs needs to be moved to BDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-08 04:14 UTC by David Michael
Modified: 2021-03-22 10:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-12-08 04:14:43 UTC 
The Git ebuilds currently have Emacs in DEPEND, which causes it to be cross-compiled.  Emacs is only needed by elisp-common.eclass, which defines $EMACS as the natively installed binary, so it needs to be moved to BDEPEND.

Reproducible: Always

Steps to Reproduce:
1. cross-emerge -v dev-vcs/git

Actual Results:  
Either this:

/var/tmp/portage/dev-vcs/git-2.26.2/temp/environment: line 1175: /usr/bin/emacs: No such file or directory
 * elisp-emacs-version: Failed to run /usr/bin/emacs
 * ERROR: dev-vcs/git-2.26.2::gentoo failed (compile phase):
 *   Could not determine Emacs version

Or this:

 * Error: circular dependencies:
(x11-libs/gtk+-3.24.24-r1:3/3::gentoo, ebuild scheduled for merge to '/usr/powerpc-gentoo-linux-gnu/') depends on
 (sys-devel/gettext-0.21:0/0::gentoo, ebuild scheduled for merge to '/usr/powerpc-gentoo-linux-gnu/') (buildtime)
  (dev-vcs/git-2.26.2:0/0::gentoo, ebuild scheduled for merge to '/usr/powerpc-gentoo-linux-gnu/') (runtime)
   (app-editors/emacs-27.1-r3:27/27::gentoo, ebuild scheduled for merge to '/usr/powerpc-gentoo-linux-gnu/') (buildtime)
    (x11-libs/gtk+-3.24.24-r1:3/3::gentoo, ebuild scheduled for merge to '/usr/powerpc-gentoo-linux-gnu/') (buildtime)

Expected Results:  
It should use the natively installed Emacs and install properly.

This affects all EAPI 7 ebuild versions >= 2.24.
Comment 1 Larry the Git Cow gentoo-dev 2021-03-22 10:06:56 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04a480fb350c265c45e938568e660a130471a183

commit 04a480fb350c265c45e938568e660a130471a183
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2021-03-22 10:06:19 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-03-22 10:06:19 +0000

    dev-vcs/git: move Emacs to BDEPEND
    
    The elisp-compile function needs a natively executable Emacs, and
    it does not need to be in RDEPEND due to a few lisp files.
    
    Closes: https://bugs.gentoo.org/759004
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-vcs/git/git-2.26.2.ebuild    | 2 +-
 dev-vcs/git/git-2.26.3.ebuild    | 2 +-
 dev-vcs/git/git-2.28.1.ebuild    | 2 +-
 dev-vcs/git/git-2.29.3.ebuild    | 2 +-
 dev-vcs/git/git-2.30.2.ebuild    | 2 +-
 dev-vcs/git/git-2.31.0-r1.ebuild | 2 +-
 dev-vcs/git/git-9999-r1.ebuild   | 2 +-
 dev-vcs/git/git-9999-r2.ebuild   | 2 +-
 dev-vcs/git/git-9999-r3.ebuild   | 2 +-
 dev-vcs/git/git-9999.ebuild      | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)