Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758839 - app-office/kmymoney quotes USE flag description inaccurate
Summary: app-office/kmymoney quotes USE flag description inaccurate
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-06 19:58 UTC by Jack
Modified: 2020-12-22 11:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2020-12-06 19:58:36 UTC
In both the main tree (5.1.0) and the KDE overlay (5.1.9999 and 9999) the description of the quotes USE flag is "Enable Online Stock Quote retrieval".  However, it should really be "Enable Online Stock quote retrieval with "dev-perl/Finance-Quote."  After disabling this flag and recompiling, KMyMoney still has several other ways to retrieve price quotes.  History: this was particularly important at various points in time when the most common source (Yahoo) was not working for most users.  
Note: the only thing I am suggesting be changed is the description in the metadata.  Nothing in the ebuild itself needs changing.

Reproducible: Always




not sure to use Trivial or Minor, as some folks might set the flag, dragging in several additional Perl modules, when it is not necessary for retrieving stock price quotes, unless the user has a specific need for this method.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-12-12 19:42:12 UTC
What is the benefit of using the method via dev-perl/Finance-Quote?
Comment 2 Jack 2020-12-15 00:34:07 UTC
I think it's primarily a matter of taste, opinion, and convenience.  KMM's internal methods are built-in and so don't need anything external, although it seems likely that we will at some point (near to mid-term) use libalkima for that, although that is essentially required anyway.

Fininace::Quote is not really better or worse than KMM's internal  methods, but I'm pretty sure it does include some sources that KMM does not otherwise use.  I originally installed it some years ago when Yahoo was being difficult.  I'm now back to using Yahoo, so I don't currently need Finance::Quote (and have actually removed it) but I think the bottom line is that it's just another option, albeit one that has an external dependency.   I'll have to re-read the ebuilds yet again, but as I remember, this USE flag actually only serves to include the dep.  If it's present, KMM can use it, if it's not present, it can't, but I don't recall any actual build time switch.

Note, all I requested was a change in the text in the Metadata entry.  What it comes down to is "If you want KMyMoney to be able to use Finance::Quote, then you need for first emerge dev-perl/Finance-Quote" but I don't know any better way to say that to users when they need to know it.  I would personally advise users to stick the the internal methods, unless it doesn't work for you, then try Finance::Quote.
Comment 3 Jack 2020-12-18 22:28:27 UTC
Note that weboob is another method of obtaining quotes.  It is not presently included in KMM, due to the previous python2 dependency.  However a python3 version of weboob is now available (and in the Portage tree) and there is a recent PR for KMM to be able to use this version, so it might get added back at some point.

Another reason for choice of which library you use for price quotes may be who supports it.
Comment 4 Andreas Sturmlechner gentoo-dev 2020-12-20 17:58:42 UTC
Well, I don't think the current IUSE name makes any sense altogether then. My first idea was to make it 'perl' instead, and use your description. Worse, then, that it is an RDEPEND only flag, seems like it has been there since 2010. This should be just dropped and replaced by optfeature. Maybe EAPI-9 will give us real runtime-only flags...

Do you know when upstream plan to make a new release? I will not make changes to the ebuild in Gentoo ebuild repo until then, but can at least improve metadata.xml for now.

(In reply to Jack from comment #3)
> However a python3 version of weboob is now available (and in the Portage
> tree) and there is a recent PR for KMM to be able to use this version
I can see neither, but you probably mean KMM upstream I guess ;)
Comment 5 Jack 2020-12-20 20:35:45 UTC
There is actually a 5.1.1 release planned for "real soon now" (maybe later December, maybe early January, the code and string freeze has already happened.)  That won't include the weboob update.  Yes, that PR is for KMM, not Gentoo - I don't think anyone has reviewed it yet.  And sorry - the updated weboob is in an overlay (laurentb) so I have no idea if/when it will make it to the official tree.
Comment 6 Jack 2020-12-20 20:39:52 UTC
I should have checked the rest of my emails.  5.1.1 has been released today.
Comment 7 Larry the Git Cow gentoo-dev 2020-12-22 11:10:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=726fdffc32849eeffcd539dc63c8dd93d9c1f2cc

commit 726fdffc32849eeffcd539dc63c8dd93d9c1f2cc
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-22 09:44:36 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-22 10:10:39 +0000

    app-office/kmymoney: Drop IUSE=quotes, use optfeature
    
    Add explanatory pkg_postinst message.
    
    Bug: https://bugs.gentoo.org/758839
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/kmymoney/kmymoney-5.1.9999.ebuild | 31 +++++++++++++++++++---------
 app-office/kmymoney/kmymoney-9999.ebuild     | 31 +++++++++++++++++++---------
 app-office/kmymoney/metadata.xml             |  1 -
 3 files changed, 42 insertions(+), 21 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2020-12-22 11:18:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06b0d8a809f73fb68fe2683677a533c300130705

commit 06b0d8a809f73fb68fe2683677a533c300130705
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-22 10:06:52 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-22 11:18:08 +0000

    app-office/kmymoney: 5.1.1 version bump
    
    - Dropping IUSE=quotes, using optfeature instead
    - Minor: Fix HOMEPAGE, some better sorting
    
    See also: https://kmymoney.org/2020/12/20/kmymoney-5-1-1-released.html
    
    Reported-by: Jack Ostroff <ostroffjh@users.sourceforge.net>
    Closes: https://bugs.gentoo.org/758839
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/kmymoney/Manifest              |   1 +
 app-office/kmymoney/kmymoney-5.1.1.ebuild | 133 ++++++++++++++++++++++++++++++
 2 files changed, 134 insertions(+)