Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758665 - dev-lang/lua-5.3.6 with USE="deprecated" is a no-op
Summary: dev-lang/lua-5.3.6 with USE="deprecated" is a no-op
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 14:38 UTC by Conrad Kostecki
Modified: 2020-12-05 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2020-12-05 14:38:30 UTC
If someone compiles lua:5.3and enables USE="deprecated", it will do nothing. It's basically a no-op, because it defines the wrong setting.

Currently, if USE="deprecated" is enabled, it will set '-DLUA_COMPAT_ALL'.
This will do nothing, as lua:5.3 doesn't know that anymore.

Instead, setting '-DLUA_COMPAT_5_2' would be correct.

Are you fine, if I do that on lua-5.3.6 too? Lua:5.4 has this correctly.
Comment 1 Larry the Git Cow gentoo-dev 2020-12-05 20:07:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82248b79ece39ab1fe482d8eb3d275a524c47762

commit 82248b79ece39ab1fe482d8eb3d275a524c47762
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2020-12-05 20:05:12 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2020-12-05 20:07:02 +0000

    dev-lang/lua: fix deprecated use flag in 5.3.6
    
    Closes: https://bugs.gentoo.org/758665
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-lang/lua/lua-5.3.6-r1.ebuild | 194 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 194 insertions(+)