Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758653 - app-emulation/libvirt-6.10.0: sedding of non-existent test Makefile
Summary: app-emulation/libvirt-6.10.0: sedding of non-existent test Makefile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 13:20 UTC by Mart Raudsepp
Modified: 2020-12-05 17:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2020-12-05 13:20:04 UTC
libvirt-6.10.0 (and probably earlier) have this in src_test:

        # remove problematic tests, bug #591416, bug #591418
        sed -i -e 's#commandtest$(EXEEXT) # #' \
                -e 's#virfirewalltest$(EXEEXT) # #' \
                -e 's#nwfilterebiptablestest$(EXEEXT) # #' \
                -e 's#nwfilterxml2firewalltest$(EXEEXT)$##' \
                tests/Makefile

But Makefile there is gone in favor of meson, so this outputs during build at the start of test phase:

sed: can't read tests/Makefile: No such file or directory

but doesn't error out, as the ebuild is missing a "|| die".

And then it fails "commandtest" tests, which are different than bug 734196, but as some test failure bugs are open, not reporting that yet separately unless requested.
Comment 1 Larry the Git Cow gentoo-dev 2020-12-05 17:22:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65296998c4e7147814af2210cee47d5c42a479c3

commit 65296998c4e7147814af2210cee47d5c42a479c3
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2020-12-05 17:21:05 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2020-12-05 17:21:35 +0000

    app-emulation/libvirt: ebuild maintenance
    
     - remove unsupported meson configure options
     - remove obsolete sed
    
    Closes: https://bugs.gentoo.org/758650
    Closes: https://bugs.gentoo.org/758653
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 app-emulation/libvirt/Manifest                     |  2 +-
 ...virt-6.10.0.ebuild => libvirt-6.10.0-r1.ebuild} | 24 ++++------------------
 2 files changed, 5 insertions(+), 21 deletions(-)
Comment 2 Matthias Maier gentoo-dev 2020-12-05 17:22:45 UTC
Yeah. The failing tests arean ongoing saga.